Ivan Ortega Alba
93c14c52da
* wip: trying to understand how to get the ds info from migrator * add datasource info provider * Use DS service to fetch DS data * add more tests cases to match with migrator cases * Add snapshots * Non-existing DS * Add different DS for snapshots * fix import * Fix tests: guard against double initialization * don't use full datasource package in test * min version should be 35 * fix test * fix conversion test * Dashboards: Support schemaVersion v35 migration in backend * Dashboards: Support schemaVersion v34 migration in backend * Dashboards: Support schemaVersion v33 migration in backend * Apply suggestions from code review Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * Apply feedback * Remove unused parameters * Refactor to follow Go patterns * Update logic * Only write final migration result as output * Compare backend and frontend results * Improve snapshots to cover all possible use cases * Linter * wip make it consistent v33 * apply feedback * Return default when the ref cannot be found * Update apps/dashboard/pkg/migration/schemaversion/v33.go Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * apply feedback * Use same mocks backend/frontend * restore migrations * update snapshots * Adapt migration tests to use min versions * Ensure v40-v41 works * Ensure v39-v40 works * Simplify the naming of the files * adjust jest to new input convention * Ensure every migration v36-v41 works * Improve v38 naming * Ensure v36 migrates correctly * Skip v36 refs migrations on rows * Treat rows as frontend and ensure same results for v36 * Ensure v34 runs with the same logic than the frontend * Leave empty stadistics as valid option * ensure v33 is working as the frontend * Update tests * Undo frontend changes for legend handling * Remove filtering by version in the frontend * linter * Clean up v33 input JSON --------- Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> Co-authored-by: Haris Rozajac <haris.rozajac12@gmail.com> Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>
43 lines
1.6 KiB
Go
43 lines
1.6 KiB
Go
package schemaversion
|
|
|
|
// V40 normalizes the dashboard refresh property to ensure consistent string typing.
|
|
//
|
|
// This migration addresses type inconsistencies in dashboard refresh configuration that could
|
|
// cause runtime errors or unexpected behavior. Over time, the refresh property has accumulated
|
|
// various data types (boolean, numeric, null, undefined) due to different dashboard creation
|
|
// methods, API usage patterns, and legacy imports.
|
|
//
|
|
// The migration works by:
|
|
// 1. Checking if the refresh property exists and is already a string type
|
|
// 2. Converting any non-string values (boolean true/false, numbers, null) to an empty string
|
|
// 3. Ensuring all dashboards have a consistent string-typed refresh property
|
|
//
|
|
// This normalization is critical because:
|
|
// - The frontend refresh logic expects string values for parsing time intervals
|
|
// - Non-string values can cause dashboard loading failures
|
|
// - Empty string is the standard representation for "no auto-refresh"
|
|
// - Consistent typing enables proper validation and UI behavior
|
|
//
|
|
// Example transformations:
|
|
//
|
|
// Before migration:
|
|
//
|
|
// refresh: true // boolean
|
|
// refresh: 30 // number (seconds)
|
|
// refresh: null // null value
|
|
// refresh: undefined // missing property
|
|
//
|
|
// After migration:
|
|
//
|
|
// refresh: "" // normalized to empty string
|
|
// refresh: "" // normalized to empty string
|
|
// refresh: "" // normalized to empty string
|
|
// refresh: "" // property added with empty string
|
|
func V40(dash map[string]interface{}) error {
|
|
dash["schemaVersion"] = int(40)
|
|
if _, ok := dash["refresh"].(string); !ok {
|
|
dash["refresh"] = ""
|
|
}
|
|
return nil
|
|
}
|