Costa Alexoglou
1b766b9c9f
* adding some logs to better understand what might be happening * only focus this PR on improve logging in finalizer handling * debug log before calling finalizers * working on finalizers * removing last todos, adding unit tests * better use SupportedFinalizers name * addressing comments * wip: fix tests and add delete error in status * chore: codegen * chore: codegen openapi * Merge remote-tracking branch 'origin/main' into provisioning-finalisers-fix-2 * update frontend client * fix: errors in testing * fix: breaking test --------- Co-authored-by: Daniele Ferru <daniele.ferru@grafana.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
87 lines
2.3 KiB
Go
87 lines
2.3 KiB
Go
package repository
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sort"
|
|
|
|
provisioning "github.com/grafana/grafana/apps/provisioning/pkg/apis/provisioning/v0alpha1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
)
|
|
|
|
type Mutator func(ctx context.Context, obj runtime.Object) error
|
|
|
|
//go:generate mockery --name=Extra --structname=MockExtra --inpackage --filename=extra_mock.go --with-expecter
|
|
type Extra interface {
|
|
Type() provisioning.RepositoryType
|
|
Build(ctx context.Context, r *provisioning.Repository) (Repository, error)
|
|
Mutate(ctx context.Context, obj runtime.Object) error
|
|
}
|
|
|
|
//go:generate mockery --name=Factory --structname=MockFactory --inpackage --filename=factory_mock.go --with-expecter
|
|
type Factory interface {
|
|
Types() []provisioning.RepositoryType
|
|
Build(ctx context.Context, r *provisioning.Repository) (Repository, error)
|
|
Mutate(ctx context.Context, obj runtime.Object) error
|
|
}
|
|
|
|
type factory struct {
|
|
extras map[provisioning.RepositoryType]Extra
|
|
enabled map[provisioning.RepositoryType]struct{}
|
|
}
|
|
|
|
func ProvideFactory(enabled map[provisioning.RepositoryType]struct{}, extras []Extra) (Factory, error) {
|
|
f := &factory{
|
|
enabled: enabled,
|
|
extras: make(map[provisioning.RepositoryType]Extra, len(extras)),
|
|
}
|
|
|
|
for _, e := range extras {
|
|
if _, exists := f.extras[e.Type()]; exists {
|
|
return nil, fmt.Errorf("repository type %q is already registered", e.Type())
|
|
}
|
|
f.extras[e.Type()] = e
|
|
}
|
|
|
|
return f, nil
|
|
}
|
|
|
|
func (f *factory) Types() []provisioning.RepositoryType {
|
|
var types []provisioning.RepositoryType
|
|
for t := range f.enabled {
|
|
if _, exists := f.extras[t]; exists {
|
|
types = append(types, t)
|
|
}
|
|
}
|
|
|
|
sort.Slice(types, func(i, j int) bool {
|
|
return string(types[i]) < string(types[j])
|
|
})
|
|
|
|
return types
|
|
}
|
|
|
|
func (f *factory) Build(ctx context.Context, r *provisioning.Repository) (Repository, error) {
|
|
for _, e := range f.extras {
|
|
if e.Type() == r.Spec.Type {
|
|
if _, enabled := f.enabled[e.Type()]; !enabled {
|
|
return nil, fmt.Errorf("repository type %q is not enabled", e.Type())
|
|
}
|
|
|
|
return e.Build(ctx, r)
|
|
}
|
|
}
|
|
|
|
return nil, fmt.Errorf("repository type %q is not supported", r.Spec.Type)
|
|
}
|
|
|
|
func (f *factory) Mutate(ctx context.Context, obj runtime.Object) error {
|
|
for _, e := range f.extras {
|
|
if err := e.Mutate(ctx, obj); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|