93c14c52da
* wip: trying to understand how to get the ds info from migrator * add datasource info provider * Use DS service to fetch DS data * add more tests cases to match with migrator cases * Add snapshots * Non-existing DS * Add different DS for snapshots * fix import * Fix tests: guard against double initialization * don't use full datasource package in test * min version should be 35 * fix test * fix conversion test * Dashboards: Support schemaVersion v35 migration in backend * Dashboards: Support schemaVersion v34 migration in backend * Dashboards: Support schemaVersion v33 migration in backend * Apply suggestions from code review Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * Apply feedback * Remove unused parameters * Refactor to follow Go patterns * Update logic * Only write final migration result as output * Compare backend and frontend results * Improve snapshots to cover all possible use cases * Linter * wip make it consistent v33 * apply feedback * Return default when the ref cannot be found * Update apps/dashboard/pkg/migration/schemaversion/v33.go Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * apply feedback * Use same mocks backend/frontend * restore migrations * update snapshots * Adapt migration tests to use min versions * Ensure v40-v41 works * Ensure v39-v40 works * Simplify the naming of the files * adjust jest to new input convention * Ensure every migration v36-v41 works * Improve v38 naming * Ensure v36 migrates correctly * Skip v36 refs migrations on rows * Treat rows as frontend and ensure same results for v36 * Ensure v34 runs with the same logic than the frontend * Leave empty stadistics as valid option * ensure v33 is working as the frontend * Update tests * Undo frontend changes for legend handling * Remove filtering by version in the frontend * linter * Clean up v33 input JSON --------- Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> Co-authored-by: Haris Rozajac <haris.rozajac12@gmail.com> Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>
42 lines
1.6 KiB
Go
42 lines
1.6 KiB
Go
package schemaversion
|
|
|
|
// V41 removes the deprecated time_options property from dashboard timepicker configuration.
|
|
//
|
|
// This migration addresses technical debt by cleaning up legacy timepicker settings that have
|
|
// been obsolete since Grafana version 5. The time_options property was originally designed to
|
|
// allow customization of predefined time range options in the time picker dropdown, but this
|
|
// functionality was superseded by more flexible time selection mechanisms.
|
|
//
|
|
// The migration works by:
|
|
// 1. Locating dashboard timepicker configuration objects
|
|
// 2. Removing the deprecated time_options property if present
|
|
// 3. Preserving all other timepicker settings (refresh_intervals, etc.)
|
|
//
|
|
// This cleanup prevents potential confusion for developers and ensures the dashboard schema
|
|
// remains focused on actively used configuration options. The removal is safe because the
|
|
// time_options property has had no functional impact for several major Grafana versions.
|
|
//
|
|
// Example transformation:
|
|
//
|
|
// Before migration:
|
|
//
|
|
// timepicker: {
|
|
// refresh_intervals: ["5s", "10s", "30s", "1m"],
|
|
// time_options: ["5m", "15m", "1h", "6h", "12h", "24h"]
|
|
// }
|
|
//
|
|
// After migration:
|
|
//
|
|
// timepicker: {
|
|
// refresh_intervals: ["5s", "10s", "30s", "1m"]
|
|
// }
|
|
func V41(dash map[string]interface{}) error {
|
|
dash["schemaVersion"] = int(41)
|
|
if timepicker, ok := dash["timepicker"].(map[string]interface{}); ok {
|
|
// time_options is a legacy property that was not used since grafana version 5
|
|
// therefore deprecating this property from the schema
|
|
delete(timepicker, "time_options")
|
|
}
|
|
return nil
|
|
}
|