4f05b42275
* Add repository resources interface for export worker * Add mocks for repository resources * Add unit tests for ExportWorker's IsSupported method * Add unit tests for ExportWorker's Process method, covering scenarios for missing export settings, write permissions, branch restrictions, and client creation failures. * Fix unit tests * Single function * Add more unit tests * Add test for failed folder * Fail export folder errors * Add another test * Positive folder export * Too many folder export errors * Too many errors on folder export * Partial folder errors * Add test for nested folder * Add test dashboard export * More cases * Ignore existing dashboards * Fix folder tests * Fix clonable test * Add clone failure test * Add test clean up without push * Working tests * Use mock clonable * Add unit tests for IsWriteAllowed * Add behaviour to cover ref equal to configured branch * Fix worker test * Fix linting * Split clone and push * Wrapper for clone and push
163 lines
4.5 KiB
Go
163 lines
4.5 KiB
Go
package repository
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
|
|
provisioning "github.com/grafana/grafana/pkg/apis/provisioning/v0alpha1"
|
|
)
|
|
|
|
func TestIsWriteAllowed(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
repository *provisioning.Repository
|
|
ref string
|
|
wantErr bool
|
|
expectedErr string
|
|
statusCode int32
|
|
}{
|
|
{
|
|
name: "read only repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Workflows: []provisioning.Workflow{},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
expectedErr: "this repository is read only",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
{
|
|
name: "write workflow allowed",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Workflows: []provisioning.Workflow{provisioning.WriteWorkflow},
|
|
},
|
|
},
|
|
ref: "",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "write allowed for configured branch of github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.GitHubRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.WriteWorkflow},
|
|
GitHub: &provisioning.GitHubRepositoryConfig{
|
|
Branch: "feature-branch",
|
|
},
|
|
},
|
|
},
|
|
ref: "feature-branch",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "write not allowed for configured branch of github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.GitHubRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.BranchWorkflow},
|
|
GitHub: &provisioning.GitHubRepositoryConfig{
|
|
Branch: "feature-branch",
|
|
},
|
|
},
|
|
},
|
|
ref: "feature-branch",
|
|
wantErr: true,
|
|
expectedErr: "this repository does not support the write workflow",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
{
|
|
name: "write workflow not allowed for github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.GitHubRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.BranchWorkflow},
|
|
GitHub: &provisioning.GitHubRepositoryConfig{
|
|
Branch: "feature-branch",
|
|
},
|
|
},
|
|
},
|
|
ref: "",
|
|
wantErr: true,
|
|
expectedErr: "this repository does not support the write workflow",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
{
|
|
name: "write workflow not allowed",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Workflows: []provisioning.Workflow{provisioning.BranchWorkflow},
|
|
},
|
|
},
|
|
wantErr: true,
|
|
expectedErr: "this repository does not support the write workflow",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
{
|
|
name: "branch workflow on non-github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.LocalRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.BranchWorkflow},
|
|
},
|
|
},
|
|
ref: "feature-branch",
|
|
wantErr: true,
|
|
expectedErr: "this repository does not support the branch workflow",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
{
|
|
name: "branch workflow allowed on github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.GitHubRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.BranchWorkflow},
|
|
},
|
|
},
|
|
ref: "feature-branch",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "branch workflow not allowed on github repository",
|
|
repository: &provisioning.Repository{
|
|
Spec: provisioning.RepositorySpec{
|
|
Type: provisioning.GitHubRepositoryType,
|
|
Workflows: []provisioning.Workflow{provisioning.WriteWorkflow},
|
|
},
|
|
},
|
|
ref: "feature-branch",
|
|
wantErr: true,
|
|
expectedErr: "this repository does not support the branch workflow",
|
|
statusCode: http.StatusBadRequest,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
err := IsWriteAllowed(tt.repository, tt.ref)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
require.Equal(t, tt.expectedErr, err.Error())
|
|
|
|
var (
|
|
statusErr *apierrors.StatusError
|
|
apiStatus apierrors.APIStatus
|
|
)
|
|
switch {
|
|
case errors.As(err, &statusErr):
|
|
require.Equal(t, tt.statusCode, statusErr.Status().Code)
|
|
case errors.As(err, &apiStatus):
|
|
require.Equal(t, tt.statusCode, apiStatus.Status().Code)
|
|
}
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|