62b85a886e
* Feature: add cron setting for the ldap settings * Move ldap configuration read to special function * Introduce cron setting (no docs for it yet, pending approval) * Chore: duplicate ldap module as a service * Feature: implement active sync This is very early preliminary implementation of active sync. There is only one thing that's going right for this code - it works. Aside from that, there is no tests, error handling, docs, transactions, it's very much duplicative and etc. But this is the overall direction with architecture I'm going for * Chore: introduce login service * Chore: gradually switch to ldap service * Chore: use new approach for auth_proxy * Chore: use new approach along with refactoring * Chore: use new ldap interface for auth_proxy * Chore: improve auth_proxy and subsequently ldap * Chore: more of the refactoring bits * Chore: address comments from code review * Chore: more refactoring stuff * Chore: make linter happy * Chore: add cron dep for grafana enterprise * Chore: initialize config package var * Chore: disable gosec for now * Chore: update dependencies * Chore: remove unused module * Chore: address review comments * Chore: make linter happy
151 lines
2.8 KiB
Go
151 lines
2.8 KiB
Go
package authproxy
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
"gopkg.in/macaron.v1"
|
|
|
|
"github.com/grafana/grafana/pkg/infra/remotecache"
|
|
"github.com/grafana/grafana/pkg/models"
|
|
"github.com/grafana/grafana/pkg/services/ldap"
|
|
"github.com/grafana/grafana/pkg/setting"
|
|
)
|
|
|
|
type TestLDAP struct {
|
|
ldap.Auth
|
|
ID int64
|
|
syncCalled bool
|
|
}
|
|
|
|
func (stub *TestLDAP) SyncUser(query *models.LoginUserQuery) error {
|
|
stub.syncCalled = true
|
|
query.User = &models.User{
|
|
Id: stub.ID,
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TestMiddlewareContext(t *testing.T) {
|
|
Convey("auth_proxy helper", t, func() {
|
|
req, _ := http.NewRequest("POST", "http://example.com", nil)
|
|
setting.AuthProxyHeaderName = "X-Killa"
|
|
name := "markelog"
|
|
|
|
req.Header.Add(setting.AuthProxyHeaderName, name)
|
|
|
|
ctx := &models.ReqContext{
|
|
Context: &macaron.Context{
|
|
Req: macaron.Request{
|
|
Request: req,
|
|
},
|
|
},
|
|
}
|
|
|
|
Convey("gets data from the cache", func() {
|
|
store := remotecache.NewFakeStore(t)
|
|
key := fmt.Sprintf(CachePrefix, name)
|
|
store.Set(key, int64(33), 0)
|
|
|
|
auth := New(&Options{
|
|
Store: store,
|
|
Ctx: ctx,
|
|
OrgID: 4,
|
|
})
|
|
|
|
id, err := auth.GetUserID()
|
|
|
|
So(err, ShouldBeNil)
|
|
So(id, ShouldEqual, 33)
|
|
})
|
|
|
|
Convey("LDAP", func() {
|
|
Convey("gets data from the LDAP", func() {
|
|
isLDAPEnabled = func() bool {
|
|
return true
|
|
}
|
|
|
|
readLDAPConfig = func() *ldap.Config {
|
|
config := &ldap.Config{
|
|
Servers: []*ldap.ServerConfig{
|
|
{},
|
|
},
|
|
}
|
|
return config
|
|
}
|
|
|
|
defer func() {
|
|
isLDAPEnabled = ldap.IsEnabled
|
|
readLDAPConfig = ldap.ReadConfig
|
|
}()
|
|
|
|
store := remotecache.NewFakeStore(t)
|
|
|
|
auth := New(&Options{
|
|
Store: store,
|
|
Ctx: ctx,
|
|
OrgID: 4,
|
|
})
|
|
|
|
stub := &TestLDAP{
|
|
ID: 42,
|
|
}
|
|
|
|
auth.LDAP = func(server *ldap.ServerConfig) ldap.IAuth {
|
|
return stub
|
|
}
|
|
|
|
id, err := auth.GetUserID()
|
|
|
|
So(err, ShouldBeNil)
|
|
So(id, ShouldEqual, 42)
|
|
So(stub.syncCalled, ShouldEqual, true)
|
|
})
|
|
|
|
Convey("gets nice error if ldap is enabled but not configured", func() {
|
|
isLDAPEnabled = func() bool {
|
|
return true
|
|
}
|
|
|
|
readLDAPConfig = func() *ldap.Config {
|
|
config := &ldap.Config{
|
|
Servers: []*ldap.ServerConfig{},
|
|
}
|
|
return config
|
|
}
|
|
|
|
defer func() {
|
|
isLDAPEnabled = ldap.IsEnabled
|
|
readLDAPConfig = ldap.ReadConfig
|
|
}()
|
|
|
|
store := remotecache.NewFakeStore(t)
|
|
|
|
auth := New(&Options{
|
|
Store: store,
|
|
Ctx: ctx,
|
|
OrgID: 4,
|
|
})
|
|
|
|
stub := &TestLDAP{
|
|
ID: 42,
|
|
}
|
|
|
|
auth.LDAP = func(server *ldap.ServerConfig) ldap.IAuth {
|
|
return stub
|
|
}
|
|
|
|
id, err := auth.GetUserID()
|
|
|
|
So(err, ShouldNotBeNil)
|
|
So(err.Error(), ShouldContainSubstring, "Failed to sync user")
|
|
So(id, ShouldNotEqual, 42)
|
|
So(stub.syncCalled, ShouldEqual, false)
|
|
})
|
|
|
|
})
|
|
})
|
|
}
|