93c14c52da
* wip: trying to understand how to get the ds info from migrator * add datasource info provider * Use DS service to fetch DS data * add more tests cases to match with migrator cases * Add snapshots * Non-existing DS * Add different DS for snapshots * fix import * Fix tests: guard against double initialization * don't use full datasource package in test * min version should be 35 * fix test * fix conversion test * Dashboards: Support schemaVersion v35 migration in backend * Dashboards: Support schemaVersion v34 migration in backend * Dashboards: Support schemaVersion v33 migration in backend * Apply suggestions from code review Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * Apply feedback * Remove unused parameters * Refactor to follow Go patterns * Update logic * Only write final migration result as output * Compare backend and frontend results * Improve snapshots to cover all possible use cases * Linter * wip make it consistent v33 * apply feedback * Return default when the ref cannot be found * Update apps/dashboard/pkg/migration/schemaversion/v33.go Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com> * apply feedback * Use same mocks backend/frontend * restore migrations * update snapshots * Adapt migration tests to use min versions * Ensure v40-v41 works * Ensure v39-v40 works * Simplify the naming of the files * adjust jest to new input convention * Ensure every migration v36-v41 works * Improve v38 naming * Ensure v36 migrates correctly * Skip v36 refs migrations on rows * Treat rows as frontend and ensure same results for v36 * Ensure v34 runs with the same logic than the frontend * Leave empty stadistics as valid option * ensure v33 is working as the frontend * Update tests * Undo frontend changes for legend handling * Remove filtering by version in the frontend * linter * Clean up v33 input JSON --------- Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> Co-authored-by: Haris Rozajac <haris.rozajac12@gmail.com> Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>
299 lines
8.4 KiB
Go
299 lines
8.4 KiB
Go
package schemaversion_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/grafana/grafana/apps/dashboard/pkg/migration/schemaversion"
|
|
)
|
|
|
|
func TestV37(t *testing.T) {
|
|
tests := []migrationTestCase{
|
|
{
|
|
name: "legend normalization with nested panels",
|
|
input: map[string]interface{}{
|
|
"title": "V37 Legend Normalization Test Dashboard",
|
|
"schemaVersion": 36,
|
|
"panels": []interface{}{
|
|
// Boolean legend true (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Panel with Boolean Legend True",
|
|
"id": 1,
|
|
"options": map[string]interface{}{
|
|
"legend": true,
|
|
},
|
|
},
|
|
// Boolean legend false (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Panel with Boolean Legend False",
|
|
"id": 2,
|
|
"options": map[string]interface{}{
|
|
"legend": false,
|
|
},
|
|
},
|
|
// Hidden displayMode (should be normalized)
|
|
map[string]interface{}{
|
|
"type": "graph",
|
|
"title": "Panel with Hidden DisplayMode",
|
|
"id": 3,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "hidden",
|
|
"placement": "bottom",
|
|
},
|
|
},
|
|
},
|
|
// ShowLegend false (should be normalized)
|
|
map[string]interface{}{
|
|
"type": "stat",
|
|
"title": "Panel with ShowLegend False",
|
|
"id": 4,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "table",
|
|
"showLegend": false,
|
|
},
|
|
},
|
|
},
|
|
// Valid legend with table displayMode (should get showLegend: true)
|
|
map[string]interface{}{
|
|
"type": "barchart",
|
|
"title": "Panel with Table Legend",
|
|
"id": 5,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "table",
|
|
"placement": "bottom",
|
|
},
|
|
},
|
|
},
|
|
// Valid legend with list displayMode (should get showLegend: true)
|
|
map[string]interface{}{
|
|
"type": "histogram",
|
|
"title": "Panel with List Legend",
|
|
"id": 6,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"placement": "right",
|
|
},
|
|
},
|
|
},
|
|
// Panel with no options (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "text",
|
|
"title": "Panel with No Options",
|
|
"id": 7,
|
|
},
|
|
// Panel with no legend config (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "gauge",
|
|
"title": "Panel with No Legend Config",
|
|
"id": 8,
|
|
"options": map[string]interface{}{
|
|
"reduceOptions": map[string]interface{}{
|
|
"fields": "/.*temperature.*/",
|
|
},
|
|
},
|
|
},
|
|
// Panel with nil legend (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "piechart",
|
|
"title": "Panel with Nil Legend",
|
|
"id": 9,
|
|
"options": map[string]interface{}{
|
|
"legend": nil,
|
|
},
|
|
},
|
|
// Row with nested panels
|
|
map[string]interface{}{
|
|
"type": "row",
|
|
"title": "Row with Nested Panels Having Various Legend Configs",
|
|
"id": 10,
|
|
"collapsed": false,
|
|
"panels": []interface{}{
|
|
// Nested panel with boolean legend (should remain unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Nested Panel with Boolean Legend",
|
|
"id": 11,
|
|
"options": map[string]interface{}{
|
|
"legend": true,
|
|
},
|
|
},
|
|
// Nested panel with hidden displayMode (should be normalized)
|
|
map[string]interface{}{
|
|
"type": "graph",
|
|
"title": "Nested Panel with Hidden DisplayMode",
|
|
"id": 12,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "hidden",
|
|
},
|
|
},
|
|
},
|
|
// Nested panel with showLegend false (should be normalized)
|
|
map[string]interface{}{
|
|
"type": "stat",
|
|
"title": "Nested Panel with ShowLegend False",
|
|
"id": 13,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "table",
|
|
"showLegend": false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expected: map[string]interface{}{
|
|
"title": "V37 Legend Normalization Test Dashboard",
|
|
"schemaVersion": 37,
|
|
"panels": []interface{}{
|
|
// Boolean legend true (unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Panel with Boolean Legend True",
|
|
"id": 1,
|
|
"options": map[string]interface{}{
|
|
"legend": true,
|
|
},
|
|
},
|
|
// Boolean legend false (unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Panel with Boolean Legend False",
|
|
"id": 2,
|
|
"options": map[string]interface{}{
|
|
"legend": false,
|
|
},
|
|
},
|
|
// Hidden displayMode (normalized)
|
|
map[string]interface{}{
|
|
"type": "graph",
|
|
"title": "Panel with Hidden DisplayMode",
|
|
"id": 3,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"showLegend": false,
|
|
"placement": "bottom",
|
|
},
|
|
},
|
|
},
|
|
// ShowLegend false (normalized)
|
|
map[string]interface{}{
|
|
"type": "stat",
|
|
"title": "Panel with ShowLegend False",
|
|
"id": 4,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"showLegend": false,
|
|
},
|
|
},
|
|
},
|
|
// Valid legend with table displayMode (showLegend added)
|
|
map[string]interface{}{
|
|
"type": "barchart",
|
|
"title": "Panel with Table Legend",
|
|
"id": 5,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "table",
|
|
"placement": "bottom",
|
|
"showLegend": true,
|
|
},
|
|
},
|
|
},
|
|
// Valid legend with list displayMode (showLegend added)
|
|
map[string]interface{}{
|
|
"type": "histogram",
|
|
"title": "Panel with List Legend",
|
|
"id": 6,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"placement": "right",
|
|
"showLegend": true,
|
|
},
|
|
},
|
|
},
|
|
// Panel with no options (unchanged)
|
|
map[string]interface{}{
|
|
"type": "text",
|
|
"title": "Panel with No Options",
|
|
"id": 7,
|
|
},
|
|
// Panel with no legend config (unchanged)
|
|
map[string]interface{}{
|
|
"type": "gauge",
|
|
"title": "Panel with No Legend Config",
|
|
"id": 8,
|
|
"options": map[string]interface{}{
|
|
"reduceOptions": map[string]interface{}{
|
|
"fields": "/.*temperature.*/",
|
|
},
|
|
},
|
|
},
|
|
// Panel with nil legend (unchanged)
|
|
map[string]interface{}{
|
|
"type": "piechart",
|
|
"title": "Panel with Nil Legend",
|
|
"id": 9,
|
|
"options": map[string]interface{}{
|
|
"legend": nil,
|
|
},
|
|
},
|
|
// Row with nested panels (nested panels processed)
|
|
map[string]interface{}{
|
|
"type": "row",
|
|
"title": "Row with Nested Panels Having Various Legend Configs",
|
|
"id": 10,
|
|
"collapsed": false,
|
|
"panels": []interface{}{
|
|
// Nested panel with boolean legend (unchanged)
|
|
map[string]interface{}{
|
|
"type": "timeseries",
|
|
"title": "Nested Panel with Boolean Legend",
|
|
"id": 11,
|
|
"options": map[string]interface{}{
|
|
"legend": true,
|
|
},
|
|
},
|
|
// Nested panel with hidden displayMode (normalized)
|
|
map[string]interface{}{
|
|
"type": "graph",
|
|
"title": "Nested Panel with Hidden DisplayMode",
|
|
"id": 12,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"showLegend": false,
|
|
},
|
|
},
|
|
},
|
|
// Nested panel with showLegend false (normalized)
|
|
map[string]interface{}{
|
|
"type": "stat",
|
|
"title": "Nested Panel with ShowLegend False",
|
|
"id": 13,
|
|
"options": map[string]interface{}{
|
|
"legend": map[string]interface{}{
|
|
"displayMode": "list",
|
|
"showLegend": false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
runMigrationTests(t, tests, schemaversion.V37)
|
|
}
|