From 112aa1674d32fd7f29eab1fe1182a921b3f441d5 Mon Sep 17 00:00:00 2001 From: Westly Wright Date: Sat, 28 Apr 2018 06:39:15 -0700 Subject: [PATCH] fix jquery error on missing id --- src/js/app.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/js/app.js b/src/js/app.js index 1b6dc85fc65..c6f612865e9 100644 --- a/src/js/app.js +++ b/src/js/app.js @@ -227,20 +227,25 @@ const bootstrapScrollSpy = function () { left: $el.offset().left, }; - console.log(scrollTop, $(window).height()) for (var i = 0; i <= $mainContentHeaders.length - 1; i++) { - var $mainContentHeadersEl = $(`#${$mainContentHeaders[i].id}`); - var hTop = $mainContentHeadersEl.offset().top; + if ($($mainContentHeaders[i]).attr('id')) { + var $mainContentHeadersEl = $(`#${$mainContentHeaders[i].id}`); + var hTop = $mainContentHeadersEl.offset().top; - if (hTop - scrollTop >= 0) { + if (hTop - scrollTop >= 0) { - $mainContentHeaders.each( ( i, a ) => { - $('#TableOfContents').find(`a[href$=${a.id}]`).removeClass('active'); - }); + $mainContentHeaders.each( ( i, a ) => { + if ($(a).attr('id')) { + $('#TableOfContents').find(`a[href$=${a.id}]`).removeClass('active'); + } + }); - $('#TableOfContents').find(`a[href$=${$mainContentHeaders[i].id}]`).addClass('active'); + $('#TableOfContents').find(`a[href$=${$mainContentHeaders[i].id}]`).addClass('active'); + break; + } + } else { break; } }