From 3aba1377a9ee8743c566ef9d84dc26febd1dcc0f Mon Sep 17 00:00:00 2001 From: Sunil Singh Date: Thu, 9 May 2024 08:40:11 -0700 Subject: [PATCH 1/2] Updating the vale.yml file with continue-on-error: true for the errata-ai/vale-action to succeeed even if the specified action fails. This is to have the vale style checker act as more of a warning and have less friction for contributors. Signed-off-by: Sunil Singh --- .github/workflows/vale.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/vale.yml b/.github/workflows/vale.yml index a695beac412..c314e33bab4 100644 --- a/.github/workflows/vale.yml +++ b/.github/workflows/vale.yml @@ -45,6 +45,7 @@ jobs: echo ${ALL_CHANGED_FILES} echo "ALL_CHANGED_FILES=$ALL_CHANGED_FILES" >> $GITHUB_ENV - uses: errata-ai/vale-action@v2.1.0 + continue-on-error: true if: steps.changed-markdown-files.outputs.any_changed == 'true' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From a128ecf144d0015ffa854b8d34ceaeee360dd833 Mon Sep 17 00:00:00 2001 From: Sunil Singh Date: Thu, 9 May 2024 09:42:45 -0700 Subject: [PATCH 2/2] Applying continue on error to all steps to avoid runner failure. Signed-off-by: Sunil Singh --- .github/workflows/vale.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/vale.yml b/.github/workflows/vale.yml index c314e33bab4..bdd2a453b3c 100644 --- a/.github/workflows/vale.yml +++ b/.github/workflows/vale.yml @@ -13,10 +13,12 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + continue-on-error: true with: fetch-depth: 0 # OR "2" -> To retrieve the preceding commit. submodules: true - name: Get all changed markdown files + continue-on-error: true id: changed-markdown-files uses: tj-actions/changed-files@v42 with: @@ -29,11 +31,13 @@ jobs: env: ALL_CHANGED_FILES: ${{ 0 }} - name: No files changed? + continue-on-error: true if: steps.changed-markdown-files.outputs.any_changed == 'false' run: | echo "No files changed" echo "ALL_CHANGED_FILES=$ALL_CHANGED_FILES" >> $GITHUB_ENV - name: List all changed files markdown files + continue-on-error: true if: steps.changed-markdown-files.outputs.any_changed == 'true' env: ALL_CHANGED_FILES: ${{ steps.changed-markdown-files.outputs.all_changed_files }}