address comments

This commit is contained in:
Jiaqi Luo
2024-01-12 15:30:18 -07:00
parent e1aa035e69
commit ce6eb37130
6 changed files with 24 additions and 24 deletions
@@ -310,7 +310,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -326,10 +327,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::
@@ -340,7 +340,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -356,10 +357,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::
@@ -310,7 +310,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -326,10 +327,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::
@@ -340,7 +340,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -356,10 +357,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::
@@ -310,7 +310,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/k3s/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -326,10 +327,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::
@@ -340,7 +340,8 @@ spec:
### additionalManifest ### additionalManifest
Specify the addition manifest(s) to be delivered to the control plane nodes. Specify additional manifests to deliver to the control plane nodes.
The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes. The value is a String, and will be placed at the path `/var/lib/rancher/rke2/server/manifests/rancher/addons.yaml` on target nodes.
Example: Example:
@@ -356,10 +357,9 @@ additionalManifest: |-
:::note :::note
It is discouraged to provide HelmChartConfig for customizing the system charts via `additionalManifest`, If you want to customize system charts, you should use the `chartValues` field as described below.
it could cause unexpected behavior due to how multiple HelmChartConfig for the same chart being handled.
The recommended approach is to utilize the `chartValues` field which is explained below. Alternatives, such as using a HelmChartConfig to customize the system charts via `additionalManifest`, can cause unexpected behavior, due to having multiple HelmChartConfigs for the same chart.
::: :::