Chore: reintroduce type assertion test + change emitted metric names (#51375)

* reintroduce type assertion test + change emitted metric names

* rename test to better eslint to be more generic

.betterer.ts

@@ -3,18 +3,14 @@ import { eslint } from '@betterer/eslint';
 
 export default {
   'no enzyme tests': () => regexp(/from 'enzyme'/g).include('**/*.test.*'),
-  'no explicit any': () =>
+  'better eslint': () =>
     eslint({
       '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/consistent-type-assertions': [
+        'error',
+        {
+          assertionStyle: 'never',
+        },
+      ],
     }).include('**/*.{ts,tsx}'),
-  // TODO reenable this test
-  // 'no type assertions': () =>
-  //   eslint({
-  //     '@typescript-eslint/consistent-type-assertions': [
-  //       'error',
-  //       {
-  //         assertionStyle: 'never',
-  //       },
-  //     ],
-  //   }).include('**/*.{ts,tsx}'),
 };

package.json

@@ -54,6 +54,7 @@
     "i18n:compile": "lingui compile",
     "postinstall": "husky install",
     "betterer": "betterer --cache",
+    "betterer:merge": "betterer merge",
     "betterer:stats": "ts-node --transpile-only --project ./scripts/cli/tsconfig.json ./scripts/cli/reportBettererStats.ts"
   },
   "grafana": {

scripts/cli/reportBettererStats.ts

@@ -11,10 +11,23 @@ async function main() {
   const results = await betterer.results();
 
   for (const testResults of results.resultSummaries) {
+    const countByMessage = {};
     const name = camelCase(testResults.name);
-    const count = Object.values(testResults.details).flatMap((v) => v).length;
+    Object.values(testResults.details)
+      .flatMap((v) => v)
+      .forEach((detail) => {
+        const message = camelCase(detail.message);
+        const metricName = `${name}_${message}`;
+        if (metricName in countByMessage) {
+          countByMessage[metricName]++;
+        } else {
+          countByMessage[metricName] = 1;
+        }
+      });
 
-    logStat(name, count);
+    for (const [metricName, count] of Object.entries<number>(countByMessage)) {
+      logStat(metricName, count);
+    }
   }
 }