Feature Toggles: Remove two AB test feature toggles (#106100)

This commit is contained in:
Nathan Marrs
2025-05-27 21:18:23 +02:00
committed by GitHub
parent 4ba378603d
commit 0178de3109
6 changed files with 4 additions and 41 deletions
@@ -845,20 +845,10 @@ export interface FeatureToggles {
*/
teamHttpHeadersTempo?: boolean;
/**
* Test feature toggle to see how cohorts could be set up AB testing
* @default false
*/
ABTestFeatureToggleA?: boolean;
/**
* Use new **Combobox** component for template variables
*/
templateVariablesUsesCombobox?: boolean;
/**
* Test feature toggle to see how cohorts could be set up AB testing
* @default false
*/
ABTestFeatureToggleB?: boolean;
/**
* Enables Advisor app
*/
grafanaAdvisor?: boolean;
-16
View File
@@ -1437,14 +1437,6 @@ var (
FrontendOnly: false,
Owner: identityAccessTeam,
},
{
Name: "ABTestFeatureToggleA",
Description: "Test feature toggle to see how cohorts could be set up AB testing",
Stage: FeatureStageExperimental,
Owner: grafanaSharingSquad,
Expression: "false",
HideFromDocs: true,
},
{
Name: "templateVariablesUsesCombobox",
Description: "Use new **Combobox** component for template variables",
@@ -1452,14 +1444,6 @@ var (
Owner: grafanaFrontendPlatformSquad,
FrontendOnly: true,
},
{
Name: "ABTestFeatureToggleB",
Description: "Test feature toggle to see how cohorts could be set up AB testing",
Stage: FeatureStageExperimental,
Owner: grafanaSharingSquad,
Expression: "false",
HideFromDocs: true,
},
{
Name: "grafanaAdvisor",
Description: "Enables Advisor app",
-2
View File
@@ -189,9 +189,7 @@ k8SFolderMove,experimental,@grafana/search-and-storage,false,false,false
improvedExternalSessionHandlingSAML,preview,@grafana/identity-access-team,false,false,false
teamHttpHeadersMimir,preview,@grafana/identity-access-team,false,false,false
teamHttpHeadersTempo,experimental,@grafana/identity-access-team,false,false,false
ABTestFeatureToggleA,experimental,@grafana/sharing-squad,false,false,false
templateVariablesUsesCombobox,experimental,@grafana/grafana-frontend-platform,false,false,true
ABTestFeatureToggleB,experimental,@grafana/sharing-squad,false,false,false
grafanaAdvisor,experimental,@grafana/plugins-platform-backend,false,false,false
elasticsearchImprovedParsing,experimental,@grafana/aws-datasources,false,false,false
datasourceConnectionsTab,privatePreview,@grafana/plugins-platform-backend,false,false,true
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
189 improvedExternalSessionHandlingSAML preview @grafana/identity-access-team false false false
190 teamHttpHeadersMimir preview @grafana/identity-access-team false false false
191 teamHttpHeadersTempo experimental @grafana/identity-access-team false false false
ABTestFeatureToggleA experimental @grafana/sharing-squad false false false
192 templateVariablesUsesCombobox experimental @grafana/grafana-frontend-platform false false true
ABTestFeatureToggleB experimental @grafana/sharing-squad false false false
193 grafanaAdvisor experimental @grafana/plugins-platform-backend false false false
194 elasticsearchImprovedParsing experimental @grafana/aws-datasources false false false
195 datasourceConnectionsTab privatePreview @grafana/plugins-platform-backend false false true
-8
View File
@@ -767,18 +767,10 @@ const (
// Enables LBAC for datasources for Tempo to apply LBAC filtering of traces to the client requests for users in teams
FlagTeamHttpHeadersTempo = "teamHttpHeadersTempo"
// FlagABTestFeatureToggleA
// Test feature toggle to see how cohorts could be set up AB testing
FlagABTestFeatureToggleA = "ABTestFeatureToggleA"
// FlagTemplateVariablesUsesCombobox
// Use new **Combobox** component for template variables
FlagTemplateVariablesUsesCombobox = "templateVariablesUsesCombobox"
// FlagABTestFeatureToggleB
// Test feature toggle to see how cohorts could be set up AB testing
FlagABTestFeatureToggleB = "ABTestFeatureToggleB"
// FlagGrafanaAdvisor
// Enables Advisor app
FlagGrafanaAdvisor = "grafanaAdvisor"
+4 -2
View File
@@ -7,7 +7,8 @@
"metadata": {
"name": "ABTestFeatureToggleA",
"resourceVersion": "1745491786560",
"creationTimestamp": "2025-01-13T21:13:13Z"
"creationTimestamp": "2025-01-13T21:13:13Z",
"deletionTimestamp": "2025-05-27T18:50:27Z"
},
"spec": {
"description": "Test feature toggle to see how cohorts could be set up AB testing",
@@ -21,7 +22,8 @@
"metadata": {
"name": "ABTestFeatureToggleB",
"resourceVersion": "1745491786560",
"creationTimestamp": "2025-01-13T21:13:13Z"
"creationTimestamp": "2025-01-13T21:13:13Z",
"deletionTimestamp": "2025-05-27T18:50:27Z"
},
"spec": {
"description": "Test feature toggle to see how cohorts could be set up AB testing",
@@ -167,9 +167,6 @@ func TestFeatureToggleFiles(t *testing.T) {
func verifyFlagsConfiguration(t *testing.T) {
legacyNames := map[string]bool{
"live-service-web-worker": true,
// TODO: Remove this when removing feature toggles
"ABTestFeatureToggleA": true,
"ABTestFeatureToggleB": true,
}
invalidNames := make([]string, 0)