Telegram: Check error before adding defer close of image (#20331)

Properly handles file opening error and returns before deferring 
close of file.

Fixes #20156

(cherry picked from commit 5b42bb58f6)
This commit is contained in:
Marcus Efraimsson
2019-11-14 08:33:19 -05:00
committed by Kyle Brandt
parent 79bfdcb122
commit 0773ae80ea
+4 -4
View File
@@ -137,6 +137,10 @@ func (tn *TelegramNotifier) buildMessageInlineImage(evalContext *alerting.EvalCo
var err error
imageFile, err = os.Open(evalContext.ImageOnDiskPath)
if err != nil {
return nil, err
}
defer func() {
err := imageFile.Close()
if err != nil {
@@ -144,10 +148,6 @@ func (tn *TelegramNotifier) buildMessageInlineImage(evalContext *alerting.EvalCo
}
}()
if err != nil {
return nil, err
}
ruleURL, err := evalContext.GetRuleURL()
if err != nil {
return nil, err