Remove double spinner (#105057)

This commit is contained in:
Gilles De Mey
2025-05-07 12:29:14 +02:00
committed by GitHub
parent c594faa64e
commit 125200c566
@@ -5,7 +5,7 @@ import { useParams } from 'react-router-dom-v5-compat';
import { GrafanaTheme2 } from '@grafana/data';
import { config, locationService } from '@grafana/runtime';
import { Alert, Button, Spinner, Stack, useStyles2 } from '@grafana/ui';
import { Alert, Button, Stack, useStyles2 } from '@grafana/ui';
import { useAppNotification } from 'app/core/copy/appNotification';
import { contextSrv } from 'app/core/core';
import { Trans, t } from 'app/core/internationalization';
@@ -279,7 +279,6 @@ export const AlertRuleForm = ({ existing, prefill, isManualRestore }: Props) =>
disabled={isSubmitting}
icon={isSubmitting ? 'spinner' : undefined}
>
{isSubmitting && <Spinner className={styles.buttonSpinner} inline={true} />}
<Trans i18nKey="alerting.alert-rule-form.action-buttons.save">Save</Trans>
</Button>
@@ -394,9 +393,6 @@ function storeInLocalStorageValues(values: RuleFormValues) {
}
const getStyles = (theme: GrafanaTheme2) => ({
buttonSpinner: css({
marginRight: theme.spacing(1),
}),
form: css({
width: '100%',
height: '100%',
@@ -409,9 +405,4 @@ const getStyles = (theme: GrafanaTheme2) => ({
maxWidth: theme.breakpoints.values.xl,
flex: 1,
}),
flexRow: css({
display: 'flex',
flexDirection: 'row',
justifyContent: 'flex-start',
}),
});