Toolkit: fix prettier error reporting (#21599)

2020-01-19 18:42:41 -08:00
parent d2b08c8368
commit 152059fec9
1 changed files with 14 additions and 13 deletions
@@ -87,22 +87,23 @@ export const prettierCheckPlugin = useSpinner<Fixable>('Prettier check', async (
        }
      })
      .then(newContents => {
-        if (fix && newContents && newContents.length > 10) {
-          return writeFile(path, newContents)
-            .then(() => {
-              console.log(`Fixed: ${path}`);
-              return true;
-            })
-            .catch(error => {
-              console.log(`Error fixing ${path}`, error);
-              return false;
-            });
+        if (newContents === undefined) {
+          return true; // Nothing to fix
        } else if (fix) {
+          if (newContents.length > 10) {
+            return writeFile(path, newContents)
+              .then(() => {
+                console.log(`Fixed: ${path}`);
+                return true;
+              })
+              .catch(error => {
+                console.log(`Error fixing ${path}`, error);
+                return false;
+              });
+          }
          console.log(`No automatic fix for: ${path}`);
-          return false;
-        } else {
-          return false;
        }
+        return false;
      })
      .then(success => ({ path, success }))
  );