public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Chore: Don't show hint for recorded queries (#78422)

Browse Source 
Don't show hint on recorded queries
This commit is contained in:
ismail simsek
2023-11-22 15:16:06 +01:00
committed by GitHub
parent f0d3e27ea7
commit 1910a734a6
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/plugins/datasource/prometheus/query_hints.test.ts
+18
View File
@@ -171,4 +171,22 @@ describe('getQueryHints()', () => {
},
});
});
it('should not return rate hint for a recorded query', () => {
const seriesCount = SUM_HINT_THRESHOLD_COUNT;
const series = Array.from({ length: seriesCount }, (_) => ({
datapoints: [
[0, 0],
[0, 0],
],
}));
let hints = getQueryHints('node_namespace_pod_container:container_cpu_usage_seconds_total:sum_irate', series);
expect(hints!.length).toBe(0);
hints = getQueryHints('node_namespace_pod_container:container_cpu_usage_seconds_total', series);
expect(hints!.length).toBe(0);
hints = getQueryHints('container_cpu_usage_seconds_total:irate_total', series);
expect(hints!.length).toBe(0);
});
});
public/app/plugins/datasource/prometheus/query_hints.ts
+1 -1
View File
@@ -32,7 +32,7 @@ export function getQueryHints(query: string, series?: any[], datasource?: Promet
// Check for need of rate()
if (query.indexOf('rate(') === -1 && query.indexOf('increase(') === -1) {
// Use metric metadata for exact types
const nameMatch = query.match(/\b(\w+_(total|sum|count))\b/);
const nameMatch = query.match(/\b((?<!:)\w+_(total|sum|count)(?!:))\b/);
let counterNameMetric = nameMatch ? nameMatch[1] : '';
const metricsMetadata = datasource?.languageProvider?.metricsMetadata;
let certain = false;