public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[v9.3.x] Prometheus: Fix Instant query time calculation (#60822)

Browse Source 
Prometheus: Fix Instant query time calculation (#60815)

* Use single point in time instead of doing time range calculation

* Comment update

(cherry picked from commit 15d32546ea)
This commit is contained in:
ismail simsek
2022-12-29 17:22:26 +01:00
committed by GitHub
parent 55a0db984d
commit 1d0dd0338c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tsdb/prometheus/client/client.go
+7 -6
View File
@@ -50,12 +50,13 @@ func (c *Client) QueryRange(ctx context.Context, q *models.Query, headers http.H
}
func (c *Client) QueryInstant(ctx context.Context, q *models.Query, headers http.Header) (*http.Response, error) {
qv := map[string]string{"query": q.Expr}
tr := q.TimeRange()
if !tr.End.IsZero() {
qv["time"] = formatTime(tr.End)
}
// We do not need a time range here.
// Instant query evaluates at a single point in time.
// Using q.TimeRange is aligning the query range to step.
// Which causes a misleading time point.
// Instead of aligning we use time point directly.
// https://prometheus.io/docs/prometheus/latest/querying/api/#instant-queries
qv := map[string]string{"query": q.Expr, "time": formatTime(q.End)}
req, err := c.createQueryRequest(ctx, "api/v1/query", qv, headers)
if err != nil {
return nil, err