public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Logs Panel: Table UI - Logs.tsx clean up mutation in react lifecycle (#78925)

Browse Source 
* remove prop mutation in componentWillUnmount
This commit is contained in:
Galen Kistler
2023-11-30 20:04:42 +00:00
committed by GitHub
parent 5af7b451d0
commit 243c7583c9
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/explore/Logs/Logs.tsx
+16 -9
View File
@@ -174,15 +174,22 @@ class UnthemedLogs extends PureComponent<Props, State> {
if (this.cancelFlippingTimer) {
window.clearTimeout(this.cancelFlippingTimer);
}
// Delete url state on unmount
if (this.props?.panelState?.logs?.columns) {
delete this.props.panelState.logs.columns;
}
if (this.props?.panelState?.logs?.refId) {
delete this.props.panelState.logs.refId;
}
if (this.props?.panelState?.logs?.labelFieldName) {
delete this.props.panelState.logs.labelFieldName;
// If we're unmounting logs (e.g. switching to another datasource), we need to remove the table specific panel state, otherwise it will persist in the explore url
if (
this.props?.panelState?.logs?.columns ||
this.props?.panelState?.logs?.refId ||
this.props?.panelState?.logs?.labelFieldName
) {
dispatch(
changePanelState(this.props.exploreId, 'logs', {
...this.props.panelState?.logs,
columns: undefined,
visualisationType: this.state.visualisationType,
labelFieldName: undefined,
refId: undefined,
})
);
}
}
updatePanelState = (logsPanelState: Partial<ExploreLogsPanelState>) => {