NewsPanel: Ensure unique HTML IDs for titles (#110344)

This commit is contained in:
Josh Hunt
2025-08-29 16:34:15 +01:00
committed by GitHub
parent 57db26a9bf
commit 2d33fead9d
@@ -1,4 +1,5 @@
import { css, cx } from '@emotion/css';
import { useId } from 'react';
import Skeleton from 'react-loading-skeleton';
import { DataFrameView, GrafanaTheme2, textUtil, dateTimeFormat } from '@grafana/data';
@@ -15,10 +16,10 @@ interface NewsItemProps {
}
function NewsComponent({ width, showImage, data, index }: NewsItemProps) {
const titleId = useId();
const styles = useStyles2(getStyles);
const useWideLayout = width > 600;
const newsItem = data.get(index);
const titleId = encodeURI(newsItem.title);
return (
<article aria-labelledby={titleId} className={cx(styles.item, useWideLayout && styles.itemWide)}>