public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Frontend sandbox: Improve signature elegibility check to avoid extra requests (#100980)

Browse Source 
* Frontend sandbox: Improve signature elegibility check to avoid extra requests

* remove caching element
This commit is contained in:
Esteban Beltran
2025-02-19 18:54:25 +02:00
committed by GitHub
parent 75c4c5ca0f
commit 2d3de82ae9
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/plugins/sandbox/sandbox_plugin_loader_registry.ts
+11 -8
View File
@@ -62,21 +62,24 @@ export async function isPluginFrontendSandboxEligible({
return false;
}
// don't run grafana-signed plugins in sandbox
// grafana signature and internal plugins are not allowed in the sandbox
return isPluginSignatureEligibleForSandbox({ pluginId });
}
async function isPluginSignatureEligibleForSandbox({ pluginId }: SandboxEligibilityCheckParams): Promise<boolean> {
try {
//this can fail if gcom is not accesible
const details = await getPluginDetails(pluginId);
return details.signatureType !== PluginSignatureType.grafana && details.signature !== 'internal';
// this can fail if we are trying to fetch settings of a non-installed plugin
const pluginMeta = await getPluginSettings(pluginId, { showErrorAlert: false });
return pluginMeta.signatureType !== PluginSignatureType.grafana && pluginMeta.signature !== 'internal';
} catch (e) {
try {
// this can fail if we are trying to fetch settings of a non-installed plugin
const pluginMeta = await getPluginSettings(pluginId, { showErrorAlert: false });
return pluginMeta.signatureType !== PluginSignatureType.grafana && pluginMeta.signature !== 'internal';
//this can fail if gcom is not accesible
const details = await getPluginDetails(pluginId);
return details.signatureType !== PluginSignatureType.grafana && details.signature !== 'internal';
} catch (e) {
return false;
}
}
return true;
}
/**