public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dynamic dashboard: Click row title should not collapse row in edit (#112786)

Browse Source 
click title should not collapse row in edit
This commit is contained in:
Oscar Kilhed
2025-10-23 11:40:08 +03:00
committed by GitHub
parent 3076f7a9b9
commit 31726e4a73
1 changed files with 25 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/dashboard-scene/scene/layout-rows/RowItemRenderer.tsx
+25 -24
View File
@@ -51,6 +51,29 @@ export function RowItemRenderer({ model }: SceneComponentProps<RowItem>) {
return <layout.Component model={layout} />;
}
const titleElement = (
<span
className={cx(
styles.rowTitle,
isHeaderHidden && styles.rowTitleHidden,
!isTopLevel && styles.rowTitleNested,
isCollapsed && styles.rowTitleCollapsed
)}
>
{!model.hasUniqueTitle() && (
<Tooltip content={t('dashboard.rows-layout.row-warning.title-not-unique', 'This title is not unique')}>
<Icon name="exclamation-triangle" />
</Tooltip>
)}
{title}
{isHeaderHidden && (
<Tooltip content={t('dashboard.rows-layout.header-hidden-tooltip', 'Row header only visible in edit mode')}>
<Icon name="eye-slash" />
</Tooltip>
)}
</span>
);
return (
<Draggable key={key!} draggableId={key!} index={myIndex} isDragDisabled={!isDraggable}>
{(dragProvided, dragSnapshot) => (
@@ -110,31 +133,9 @@ export function RowItemRenderer({ model }: SceneComponentProps<RowItem>) {
data-testid={selectors.components.DashboardRow.title(title!)}
>
<Icon name={isCollapsed ? 'angle-right' : 'angle-down'} />
<span
className={cx(
styles.rowTitle,
isHeaderHidden && styles.rowTitleHidden,
!isTopLevel && styles.rowTitleNested,
isCollapsed && styles.rowTitleCollapsed
)}
>
{!model.hasUniqueTitle() && (
<Tooltip
content={t('dashboard.rows-layout.row-warning.title-not-unique', 'This title is not unique')}
>
<Icon name="exclamation-triangle" />
</Tooltip>
)}
{title}
{isHeaderHidden && (
<Tooltip
content={t('dashboard.rows-layout.header-hidden-tooltip', 'Row header only visible in edit mode')}
>
<Icon name="eye-slash" />
</Tooltip>
)}
</span>
{!isEditing && titleElement}
</button>
{isEditing && titleElement}
{isDraggable && <Icon name="draggabledots" className="dashboard-row-header-drag-handle" />}
</div>
)}