public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Add Missing Quotes to Failed Evaluations Queries (#99067)

Browse Source 
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
This commit is contained in:
SeamusGrafana
2025-01-17 16:43:33 +00:00
committed by GitHub
co-authored by Gilles De Mey
parent 55644faa9d
commit 40baca699a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/alerting/unified/insights/mimir/perGroup/RuleGroupEvaluationsScene.tsx
+2 -2
View File
@@ -6,11 +6,11 @@ import { InsightsMenuButton } from '../../InsightsMenuButton';
export function getRuleGroupEvaluationsScene(datasource: DataSourceRef, panelTitle: string) {
const exprA = INSTANCE_ID
? `grafanacloud_instance_rule_evaluations_total:rate5m{rule_group="$rule_group", id="${INSTANCE_ID}} - grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group", id="${INSTANCE_ID}}`
? `grafanacloud_instance_rule_evaluations_total:rate5m{rule_group="$rule_group", id="${INSTANCE_ID}"} - grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group", id="${INSTANCE_ID}"}`
: `grafanacloud_instance_rule_evaluations_total:rate5m{rule_group="$rule_group"} - grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group"}`;
const exprB = INSTANCE_ID
? `grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group", id="${INSTANCE_ID}}`
? `grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group", id="${INSTANCE_ID}"}`
: `grafanacloud_instance_rule_evaluation_failures_total:rate5m{rule_group=~"$rule_group"}`;
const query = new SceneQueryRunner({
public/app/features/alerting/unified/insights/mimir/rules/EvalSuccessVsFailuresScene.tsx
+2 -2
View File
@@ -6,11 +6,11 @@ import { InsightsMenuButton } from '../../InsightsMenuButton';
export function getEvalSuccessVsFailuresScene(datasource: DataSourceRef, panelTitle: string) {
const exprA = INSTANCE_ID
? `sum(grafanacloud_instance_rule_evaluations_total:rate5m{id="${INSTANCE_ID}) - sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m{id="${INSTANCE_ID})`
? `sum(grafanacloud_instance_rule_evaluations_total:rate5m{id="${INSTANCE_ID}"}) - sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m{id="${INSTANCE_ID}"})`
: `sum(grafanacloud_instance_rule_evaluations_total:rate5m) - sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m)`;
const exprB = INSTANCE_ID
? `sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m{id="${INSTANCE_ID})`
? `sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m{id="${INSTANCE_ID}"})`
: `sum(grafanacloud_instance_rule_evaluation_failures_total:rate5m)`;
const query = new SceneQueryRunner({