Folders: Fix user setting in api (#102329)

This commit is contained in:
Stephanie Hingtgen
2025-03-17 18:33:09 -05:00
committed by GitHub
parent c45a342303
commit 4755da0ff5
3 changed files with 11 additions and 4 deletions
+6 -4
View File
@@ -2,10 +2,12 @@ package folders
import (
"fmt"
"strconv"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
claims "github.com/grafana/authlib/types"
"github.com/grafana/grafana/pkg/apimachinery/utils"
"github.com/grafana/grafana/pkg/apis/folder/v0alpha1"
"github.com/grafana/grafana/pkg/services/apiserver/endpoints/request"
@@ -70,11 +72,11 @@ func convertToK8sResource(v *folder.Folder, namespacer request.NamespaceMapper)
// We're going to have to align with that. For now we do need the user ID because the folder type stores it
// as the only user identifier
if v.CreatedByUID != "" {
meta.SetCreatedBy(v.UpdatedByUID)
if v.CreatedBy != 0 {
meta.SetCreatedBy(claims.NewTypeID(claims.TypeUser, strconv.FormatInt(v.CreatedBy, 10)))
}
if v.UpdatedByUID != "" {
meta.SetUpdatedBy(v.UpdatedByUID)
if v.UpdatedBy != 0 {
meta.SetUpdatedBy(claims.NewTypeID(claims.TypeUser, strconv.FormatInt(v.UpdatedBy, 10)))
}
if v.ParentUID != "" {
meta.SetFolder(v.ParentUID)
+3
View File
@@ -366,6 +366,9 @@ func (s *Service) GetLegacy(ctx context.Context, q *folder.GetFolderQuery) (*fol
f.FullpathUIDs = f.UID // set full path to the folder UID
}
f.CreatedBy = dashFolder.CreatedBy
f.UpdatedBy = dashFolder.UpdatedBy
return f, err
}
@@ -1998,6 +1998,8 @@ func TestFolderServiceGetFolder(t *testing.T) {
fldr, err := tc.svc.Get(context.Background(), &q)
require.NoError(t, err)
require.Equal(t, f.UID, fldr.UID)
require.Equal(t, f.CreatedBy, fldr.CreatedBy)
require.Equal(t, f.UpdatedBy, fldr.CreatedBy)
require.Equal(t, tc.expectedFullpath, fldr.Fullpath)
})