PanelChrome: Put overflow: hidden; behind a feature toggle for safety (#112580)

put overflow: hidden behind a feature toggle for safety
This commit is contained in:
Ashley Harrison
2025-10-17 15:40:08 +01:00
committed by GitHub
parent 083f12d06e
commit 4cf11b721a
7 changed files with 35 additions and 1 deletions
@@ -111,6 +111,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general-
| `logsPanelControls` | Enables a control component for the logs panel in Explore |
| `grafanaPathfinder` | Enables Pathfinder app |
| `azureResourcePickerUpdates` | Enables the updated Azure Monitor resource picker |
| `preventPanelChromeOverflow` | Restrict PanelChrome contents with overflow: hidden; |
## Development feature toggles
@@ -1213,4 +1213,9 @@ export interface FeatureToggles {
* @default false
*/
cdnPluginsUrls?: boolean;
/**
* Restrict PanelChrome contents with overflow: hidden;
* @default true
*/
preventPanelChromeOverflow?: boolean;
}
@@ -10,6 +10,7 @@ import { t } from '@grafana/i18n';
import { useStyles2, useTheme2 } from '../../themes/ThemeContext';
import { getFocusStyles } from '../../themes/mixins';
import { DelayRender } from '../../utils/DelayRender';
import { getFeatureToggle } from '../../utils/featureToggle';
import { usePointerDistance } from '../../utils/usePointerDistance';
import { useElementSelection } from '../ElementSelectionContext/ElementSelectionContext';
import { Icon } from '../Icon/Icon';
@@ -484,7 +485,7 @@ const getStyles = (theme: GrafanaTheme2) => {
height: '100%',
display: 'flex',
flexDirection: 'column',
overflow: 'hidden',
overflow: getFeatureToggle('preventPanelChromeOverflow') ? 'hidden' : 'initial',
'.always-show': {
background: 'none',
+8
View File
@@ -2103,6 +2103,14 @@ var (
Owner: grafanaPluginsPlatformSquad,
Expression: "false",
},
{
Name: "preventPanelChromeOverflow",
Description: "Restrict PanelChrome contents with overflow: hidden;",
Stage: FeatureStagePublicPreview,
FrontendOnly: true,
Owner: grafanaFrontendPlatformSquad,
Expression: "true",
},
}
)
+1
View File
@@ -270,3 +270,4 @@ pluginContainers,privatePreview,@grafana/plugins-platform-backend,false,true,fal
tempoSearchBackendMigration,GA,@grafana/oss-big-tent,false,true,false
cdnPluginsLoadFirst,experimental,@grafana/plugins-platform-backend,false,false,false
cdnPluginsUrls,experimental,@grafana/plugins-platform-backend,false,false,false
preventPanelChromeOverflow,preview,@grafana/grafana-frontend-platform,false,false,true
1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
270 tempoSearchBackendMigration GA @grafana/oss-big-tent false true false
271 cdnPluginsLoadFirst experimental @grafana/plugins-platform-backend false false false
272 cdnPluginsUrls experimental @grafana/plugins-platform-backend false false false
273 preventPanelChromeOverflow preview @grafana/grafana-frontend-platform false false true
+4
View File
@@ -1089,4 +1089,8 @@ const (
// FlagCdnPluginsUrls
// Enable loading plugins via declarative URLs
FlagCdnPluginsUrls = "cdnPluginsUrls"
// FlagPreventPanelChromeOverflow
// Restrict PanelChrome contents with overflow: hidden;
FlagPreventPanelChromeOverflow = "preventPanelChromeOverflow"
)
+14
View File
@@ -3038,6 +3038,20 @@
"hideFromDocs": true
}
},
{
"metadata": {
"name": "preventPanelChromeOverflow",
"resourceVersion": "1760704390127",
"creationTimestamp": "2025-10-17T12:33:10Z"
},
"spec": {
"description": "Restrict PanelChrome contents with overflow: hidden;",
"stage": "preview",
"codeowner": "@grafana/grafana-frontend-platform",
"frontend": true,
"expression": "true"
}
},
{
"metadata": {
"name": "promQLScope",