public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Chore: clean up console warning from Resource Picker tests (#46664)

Browse Source
This commit is contained in:
Kevin Yu
2022-03-17 06:55:14 -07:00
committed by GitHub
parent ed155e47c4
commit 50bbbbf376
1 changed files with 41 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/plugins/datasource/grafana-azure-monitor-datasource/components/ResourcePicker/ResourcePicker.test.tsx
+41 -49
View File
@@ -1,4 +1,4 @@
import { act, render, screen, waitFor } from '@testing-library/react';
import { render, screen } from '@testing-library/react';
import React from 'react';
import ResourcePicker from '.';
@@ -28,19 +28,17 @@ describe('AzureMonitor ResourcePicker', () => {
getResourceGroupsBySubscriptionId: jest.fn(),
getResourcesForResourceGroup: jest.fn(),
});
await act(() => {
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={noResourceURI}
onCancel={noop}
onApply={noop}
/>
);
});
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={noResourceURI}
onCancel={noop}
onApply={noop}
/>
);
await waitFor(() => expect(screen.getByText('Primary Subscription')).toBeInTheDocument());
expect(await screen.findByText('Primary Subscription')).toBeInTheDocument();
expect(resourePickerDataMock.getSubscriptions).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).not.toHaveBeenCalled();
expect(resourePickerDataMock.getResourcesForResourceGroup).not.toHaveBeenCalled();
@@ -54,19 +52,17 @@ describe('AzureMonitor ResourcePicker', () => {
getResourceGroupsBySubscriptionId: jest.fn(),
getResourcesForResourceGroup: jest.fn(),
});
await act(async () => {
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleSubscriptionSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
});
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleSubscriptionSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
await waitFor(() => expect(screen.getByText('Primary Subscription')).toBeInTheDocument());
expect(await screen.findByText('Primary Subscription')).toBeInTheDocument();
expect(resourePickerDataMock.getSubscriptions).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).not.toHaveBeenCalled();
expect(resourePickerDataMock.getResourcesForResourceGroup).not.toHaveBeenCalled();
@@ -80,19 +76,17 @@ describe('AzureMonitor ResourcePicker', () => {
getResourceGroupsBySubscriptionId: jest.fn().mockResolvedValue(createMockResourceGroupsBySubscription()),
getResourcesForResourceGroup: jest.fn(),
});
await act(async () => {
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleResourceGroupSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
});
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleResourceGroupSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
await waitFor(() => expect(screen.getByText('Primary Subscription')).toBeInTheDocument());
expect(await screen.findByText('Primary Subscription')).toBeInTheDocument();
expect(resourePickerDataMock.getSubscriptions).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).toHaveBeenLastCalledWith(
@@ -109,19 +103,17 @@ describe('AzureMonitor ResourcePicker', () => {
getResourceGroupsBySubscriptionId: jest.fn().mockResolvedValue(createMockResourceGroupsBySubscription()),
getResourcesForResourceGroup: jest.fn().mockResolvedValue(mockResourcesByResourceGroup()),
});
await act(async () => {
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleResourceSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
});
render(
<ResourcePicker
templateVariables={[]}
resourcePickerData={resourePickerDataMock}
resourceURI={singleResourceSelectionURI}
onCancel={noop}
onApply={noop}
/>
);
await waitFor(() => expect(screen.getByText('Primary Subscription')).toBeInTheDocument());
expect(await screen.findByText('Primary Subscription')).toBeInTheDocument();
expect(resourePickerDataMock.getSubscriptions).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).toHaveBeenCalledTimes(1);
expect(resourePickerDataMock.getResourceGroupsBySubscriptionId).toHaveBeenLastCalledWith(