public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(provisioning): clarify that versionClients map is shared via closure

Browse Source 
- The versionClients map is captured in the shim closure
- When the shim is reused, the same map is shared across all dashboard conversion calls
- This ensures client caching works correctly when exporting multiple dashboards
- Add clarifying comments to document the sharing behavior
This commit is contained in:
Roberto Jimenez Sanchez
2025-12-02 19:36:43 +01:00
parent 244516cec2
commit 513357e5f9
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/registry/apis/provisioning/jobs/export/resources.go
+4 -4
View File
@@ -138,9 +138,8 @@ func ExportSpecificResources(ctx context.Context, options provisioning.ExportJob
}
// Create a shared dashboard conversion shim and cache for all dashboard resources
// The versionClients map will be shared across all dashboard conversion calls
// The versionClients map is captured in the shim closure and shared across all calls
var dashboardShim conversionShim
var versionClients map[string]dynamic.ResourceInterface
for _, resourceRef := range options.Resources {
result := jobs.JobResourceResult{
@@ -235,9 +234,10 @@ func ExportSpecificResources(ctx context.Context, options provisioning.ExportJob
// Handle dashboard version conversion using the shared shim logic
if gvr.GroupResource() == resources.DashboardResource.GroupResource() {
// Create or reuse the dashboard shim (shared across all dashboard resources)
// The versionClients map is shared across all calls to preserve client caching
// The versionClients map is captured in the shim closure and shared across all calls
// This ensures client caching works correctly when exporting multiple dashboards
if dashboardShim == nil {
dashboardShim, versionClients = createDashboardConversionShim(ctx, clients, gvr)
dashboardShim, _ = createDashboardConversionShim(ctx, clients, gvr)
}
item, err = dashboardShim(ctx, item)