public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(unified-strorage): optimize allocations (#110448)

Browse Source
This commit is contained in:
Jean-Philippe Quéméner
2025-09-02 15:43:48 +02:00
committed by GitHub
parent 2a5ba2e74a
commit 5fb72d1b04
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/storage/unified/search/bleve.go
+5 -11
View File
@@ -1254,16 +1254,10 @@ func (b *bleveIndex) runUpdater(ctx context.Context) {
return
}
// Build reasons map
reasons := map[string]int{}
for _, req := range batch {
reasons[req.reason]++
}
var rv int64
var err = ctx.Err()
if err == nil {
rv, err = b.updateIndexWithLatestModifications(ctx, len(batch), reasons)
rv, err = b.updateIndexWithLatestModifications(ctx, len(batch))
}
for _, req := range batch {
req.callback <- updateResult{rv: rv, err: err}
@@ -1271,12 +1265,12 @@ func (b *bleveIndex) runUpdater(ctx context.Context) {
}
}
func (b *bleveIndex) updateIndexWithLatestModifications(ctx context.Context, requests int, reasons map[string]int) (int64, error) {
func (b *bleveIndex) updateIndexWithLatestModifications(ctx context.Context, requests int) (int64, error) {
ctx, span := b.tracing.Start(ctx, tracingPrexfixBleve+"updateIndexWithLatestModifications")
defer span.End()
sinceRV := b.resourceVersion
b.logger.Debug("Updating index", "sinceRV", sinceRV, "requests", requests, "reasons", reasons)
b.logger.Debug("Updating index", "sinceRV", sinceRV, "requests", requests)
startTime := time.Now()
listRV, docs, err := b.updaterFn(ctx, b, sinceRV)
@@ -1286,7 +1280,7 @@ func (b *bleveIndex) updateIndexWithLatestModifications(ctx context.Context, req
elapsed := time.Since(startTime)
if err == nil {
b.logger.Debug("Finished updating index", "sinceRV", sinceRV, "listRV", listRV, "duration", elapsed, "docs", docs, "reasons", reasons)
b.logger.Debug("Finished updating index", "sinceRV", sinceRV, "listRV", listRV, "duration", elapsed, "docs", docs)
if b.updateLatency != nil {
b.updateLatency.Observe(elapsed.Seconds())
@@ -1308,7 +1302,7 @@ func safeInt64ToInt(i64 int64) (int, error) {
}
func getSortFields(req *resourcepb.ResourceSearchRequest) []string {
sorting := []string{}
sorting := make([]string, 0, len(req.SortBy))
for _, sort := range req.SortBy {
input := sort.Field
if field, ok := textSortFields[input]; ok {