Chore: Upgrade Go to 1.19.2 (#56857)

We also need to upgrade the linter together with the Go version, all the changes should relate to either fixing linting problems or upgrading the Go version used to build Grafana.

.bingo/drone.mod

@@ -1,7 +1,8 @@
 module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT
 
-go 1.17
+go 1.19
 
 replace github.com/docker/docker => github.com/docker/engine v17.12.0-ce-rc1.0.20200309214505-aa6a9891b09c+incompatible
 
 require github.com/drone/drone-cli v1.4.0 // drone
+require golang.org/x/sys v0.0.0-20221010170243-090e33056c14 

.bingo/go.mod

@@ -1 +1,3 @@
-module _ // Fake go.mod auto-created by 'bingo' for go -moddir compatibility with non-Go projects. Commit this file, together with other .mod files.
+module _ // Fake go.mod auto-created by 'bingo' for go -moddir compatibility with non-Go projects. Commit this file, together with other .mod files.
+
+go 1.19

.gitignore

@@ -59,6 +59,7 @@ public/css/*.min.css
 *.sublime-workspace
 *.swp
 .idea/
+.fleet/
 *.iml
 *.tmp
 .DS_Store

Dockerfile

@@ -20,7 +20,7 @@ COPY emails emails
 ENV NODE_ENV production
 RUN yarn build
 
-FROM golang:1.17.11-alpine3.15 as go-builder
+FROM golang:1.19.2-alpine3.15 as go-builder
 
 RUN apk add --no-cache gcc g++ make
 

Dockerfile.ubuntu

@@ -21,7 +21,7 @@ COPY emails emails
 ENV NODE_ENV production
 RUN yarn build
 
-FROM golang:1.17.11 AS go-builder
+FROM golang:1.19.2 AS go-builder
 
 WORKDIR /src/grafana
 

devenv/docker/blocks/alert_webhook_listener/main.go

@@ -3,7 +3,7 @@ package main
 import (
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"log"
 	"net/http"
 	"strings"
@@ -25,5 +25,6 @@ func hello(w http.ResponseWriter, r *http.Request) {
 
 func main() {
 	http.HandleFunc("/", hello)
+	//nolint:gosec
 	log.Fatal(http.ListenAndServe(":3010", nil))
 }

devenv/docker/blocks/slow_proxy/main.go

@@ -47,5 +47,6 @@ func main() {
 		proxy.ServeHTTP(w, r)
 	})
 
+	//nolint:gosec
 	log.Fatal(http.ListenAndServe(":3011", nil))
 }

pkg/api/alerting.go

@@ -553,7 +553,7 @@ func (hs *HTTPServer) PauseAlert(c *models.ReqContext) response.Response {
 		return response.Error(500, "", err)
 	}
 
-	var resp models.AlertStateType = models.AlertStateUnknown
+	var resp = models.AlertStateUnknown
 	pausedState := "un-paused"
 	if cmd.Paused {
 		resp = models.AlertStatePaused
@@ -579,7 +579,7 @@ func (hs *HTTPServer) PauseAllAlerts(c *models.ReqContext) response.Response {
 		return response.Error(500, "Failed to pause alerts", err)
 	}
 
-	var resp models.AlertStateType = models.AlertStatePending
+	var resp = models.AlertStatePending
 	pausedState := "un paused"
 	if updateCmd.Paused {
 		resp = models.AlertStatePaused

pkg/api/avatar/avatar.go

@@ -11,7 +11,7 @@ import (
 	"bytes"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"path/filepath"

pkg/api/dashboard_test.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/docs/merge/merge_specs.go

@@ -6,7 +6,7 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"strings"
 
@@ -84,6 +84,7 @@ func mergeSpecs(output string, sources ...string) error {
 		return fmt.Errorf("failed to intend new spec: %w", err)
 	}
 
+	//nolint:gosec
 	f, err = os.Create(output)
 	if err != nil {
 		return fmt.Errorf("failed to create file for new spec: %w", err)

pkg/api/frontend_logging_test.go

@@ -2,7 +2,7 @@ package api
 
 import (
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/url"
 	"os"
 	"strings"

pkg/api/frontendlogging/source_maps.go

@@ -1,7 +1,7 @@
 package frontendlogging
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/api/login_test.go

@@ -7,7 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"strings"

pkg/api/plugin_dashboards_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/plugin_metrics_test.go

@@ -2,7 +2,7 @@ package api
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/pluginproxy/ds_proxy.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"strconv"

pkg/api/pluginproxy/ds_proxy_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"net/url"

pkg/api/pluginproxy/pluginproxy.go

@@ -3,7 +3,7 @@ package pluginproxy
 import (
 	"bytes"
 	"encoding/json"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httputil"
 	"net/url"

pkg/api/pluginproxy/pluginproxy_test.go

@@ -2,7 +2,7 @@ package pluginproxy
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"testing"

pkg/api/pluginproxy/utils.go

@@ -3,7 +3,7 @@ package pluginproxy
 import (
 	"bytes"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 	"text/template"

pkg/api/plugins.go

@@ -6,7 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/api/plugins_test.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"os"

pkg/build/fs.go

@@ -49,6 +49,7 @@ func shaFile(file string) error {
 		return err
 	}
 
+	//nolint:gosec
 	out, err := os.Create(file + ".sha256")
 	if err != nil {
 		return err
@@ -77,6 +78,7 @@ func md5File(file string) error {
 		return err
 	}
 
+	//nolint:gosec
 	out, err := os.Create(file + ".md5")
 	if err != nil {
 		return err

pkg/cmd/grafana-cli/services/api_client.go

@@ -7,7 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/cmd/grafana-cli/services/api_client_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"errors"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/cmd/grafana-cli/services/io_util.go

@@ -1,7 +1,7 @@
 package services
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 )
 

pkg/cmd/grafana-server/commands/cli.go

@@ -97,6 +97,10 @@ func RunServer(opt ServerOptions) int {
 		fmt.Println("diagnostics: pprof profiling enabled", "addr", profileDiagnostics.addr, "port", profileDiagnostics.port)
 		runtime.SetBlockProfileRate(1)
 		go func() {
+			// TODO: We should enable the linter and fix G114 here.
+			//	G114: Use of net/http serve function that has no support for setting timeouts (gosec)
+			//
+			//nolint:gosec
 			err := http.ListenAndServe(fmt.Sprintf("%s:%d", profileDiagnostics.addr, profileDiagnostics.port), nil)
 			if err != nil {
 				panic(err)

pkg/components/imguploader/azureblobuploader.go

@@ -9,7 +9,7 @@ import (
 	"encoding/xml"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"mime"
 	"net/http"
 	"net/url"

pkg/components/imguploader/gcs/gcsuploader.go

@@ -5,7 +5,7 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path"
 	"path/filepath"

pkg/components/imguploader/gcs/gcsuploader_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"testing"
 	"time"

pkg/components/imguploader/webdavuploader.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net"
 	"net/http"
 	"net/url"

pkg/infra/filestorage/fs_integration_test.go

@@ -7,7 +7,7 @@ import (
 	"context"
 	"encoding/base64"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path"
 	"testing"

pkg/infra/fs/copy.go

@@ -3,7 +3,7 @@ package fs
 import (
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 )
@@ -76,6 +76,7 @@ func copyFileContents(src, dst string) (err error) {
 		}
 	}()
 
+	//nolint:gosec
 	out, err := os.Create(dst)
 	if err != nil {
 		return

pkg/infra/fs/copy_test.go

@@ -1,7 +1,7 @@
 package fs
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/infra/fs/exists_test.go

@@ -1,7 +1,7 @@
 package fs
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"testing"
 

pkg/infra/httpclient/count_bytes_reader_test.go

@@ -2,7 +2,7 @@ package httpclient
 
 import (
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"strings"
 	"testing"
 

pkg/infra/httpclient/httpclientprovider/response_limit_middleware_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 	"testing"

pkg/infra/httpclient/max_bytes_reader_test.go

@@ -3,7 +3,7 @@ package httpclient
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"strings"
 	"testing"
 

pkg/infra/log/log.go

@@ -7,7 +7,7 @@ package log
 import (
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"sort"

pkg/infra/usagestats/service/usage_stats_test.go

@@ -5,7 +5,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"runtime"

pkg/infra/usagestats/statscollector/prometheus_flavor.go

@@ -3,7 +3,7 @@ package statscollector
 import (
 	"context"
 	"encoding/json"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"time"
 

pkg/login/social/common.go

@@ -4,7 +4,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 

pkg/login/social/generic_oauth.go

@@ -7,7 +7,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/mail"
 	"regexp"

pkg/login/social/social.go

@@ -4,7 +4,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 

pkg/middleware/recovery.go

@@ -19,7 +19,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"runtime"
 

pkg/plugins/backendplugin/grpcplugin/log_wrapper.go

@@ -3,7 +3,7 @@ package grpcplugin
 import (
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"log"
 
 	glog "github.com/grafana/grafana/pkg/infra/log"

pkg/plugins/manager/installer/installer.go

@@ -11,7 +11,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net"
 	"net/http"
 	"net/url"

pkg/plugins/manager/installer/installer_test.go

@@ -3,7 +3,7 @@ package installer
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"runtime"
@@ -47,6 +47,7 @@ func TestUninstall(t *testing.T) {
 
 	pluginDir := t.TempDir()
 	pluginJSON := filepath.Join(pluginDir, "plugin.json")
+	//nolint:gosec
 	_, err := os.Create(pluginJSON)
 	require.NoError(t, err)
 
@@ -61,6 +62,7 @@ func TestUninstall(t *testing.T) {
 		err = os.Mkdir(pluginDistDir, os.ModePerm)
 		require.NoError(t, err)
 		pluginJSON = filepath.Join(pluginDistDir, "plugin.json")
+		//nolint:gosec
 		_, err = os.Create(pluginJSON)
 		require.NoError(t, err)
 

pkg/plugins/manager/signature/manifest.go

@@ -8,7 +8,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/url"
 	"os"
 	"path"

pkg/schema/load/load_test.go

@@ -7,7 +7,7 @@ import (
 	"fmt"
 	"io"
 	"io/fs"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"sort"

pkg/schema/load/panel.go

@@ -5,7 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"io/fs"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 
 	"cuelang.org/go/cue"

pkg/schema/schema_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"strings"
 	"testing"

pkg/server/server.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net"
 	"os"
 	"path/filepath"

pkg/services/alerting/alerting_usage_test.go

@@ -3,7 +3,7 @@ package alerting
 import (
 	"context"
 	"encoding/json"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"testing"
 
 	"github.com/google/go-cmp/cmp"

pkg/services/alerting/extractor_test.go

@@ -3,7 +3,7 @@ package alerting
 import (
 	"context"
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"testing"
 	"time"
 

pkg/services/alerting/notifiers/hipchat.go

@@ -55,9 +55,7 @@ const (
 // for the HipChatNotifier
 func NewHipChatNotifier(model *models.AlertNotification, _ alerting.GetDecryptedValueFn, ns notifications.Service) (alerting.Notifier, error) {
 	url := model.Settings.Get("url").MustString()
-	if strings.HasSuffix(url, "/") {
-		url = url[:len(url)-1]
-	}
+	url = strings.TrimSuffix(url, "/")
 	if url == "" {
 		return nil, alerting.ValidationError{Reason: "Could not find url property in settings"}
 	}

pkg/services/auth/jwt/auth_test.go

@@ -6,7 +6,7 @@ import (
 	"encoding/base64"
 	"encoding/json"
 	"encoding/pem"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"os"

pkg/services/auth/jwt/key_sets.go

@@ -9,7 +9,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/services/auth/jwt/validation.go

@@ -35,8 +35,8 @@ func (s *AuthService) initClaimExpectations() error {
 			switch value := value.(type) {
 			case []interface{}:
 				for _, val := range value {
-					if val, ok := val.(string); ok {
-						s.expectRegistered.Audience = append(s.expectRegistered.Audience, val)
+					if v, ok := val.(string); ok {
+						s.expectRegistered.Audience = append(s.expectRegistered.Audience, v)
 					} else {
 						return fmt.Errorf("%q expectation contains value with invalid type %T, string expected", key, val)
 					}
@@ -73,8 +73,8 @@ func (s *AuthService) validateClaims(claims models.JWTClaims) error {
 			switch value := value.(type) {
 			case []interface{}:
 				for _, val := range value {
-					if val, ok := val.(string); ok {
-						registeredClaims.Audience = append(registeredClaims.Audience, val)
+					if v, ok := val.(string); ok {
+						registeredClaims.Audience = append(registeredClaims.Audience, v)
 					} else {
 						return fmt.Errorf("%q claim contains value with invalid type %T, string expected", key, val)
 					}

pkg/services/cleanup/cleanup.go

@@ -3,7 +3,7 @@ package cleanup
 import (
 	"context"
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path"
 	"time"

pkg/services/contexthandler/contexthandler.go

@@ -29,6 +29,8 @@ import (
 
 const (
 	InvalidUsernamePassword = "invalid username or password"
+	// False positive.
+	//nolint:gosec
 	InvalidAPIKey           = "invalid API key"
 )
 

pkg/services/dashboardimport/service/service_test.go

@@ -2,7 +2,7 @@ package service
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"testing"
 

pkg/services/datasources/service/datasource_service_test.go

@@ -2,7 +2,7 @@ package service
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"testing"

pkg/services/featuremgmt/settings.go

@@ -1,7 +1,7 @@
 package featuremgmt
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 
 	"gopkg.in/yaml.v2"
 )

pkg/services/featuremgmt/toggles_gen_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"fmt"
 	"html/template"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"
@@ -92,6 +92,7 @@ func isLetterOrNumber(c rune) bool {
 func asCamelCase(key string) string {
 	parts := strings.FieldsFunc(key, isLetterOrNumber)
 	for idx, part := range parts {
+		//nolint:staticcheck
 		parts[idx] = strings.Title(part)
 	}
 	return strings.Join(parts, "")

pkg/services/ldap/ldap.go

@@ -5,7 +5,7 @@ import (
 	"crypto/x509"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"math"
 	"net"
 	"strconv"

pkg/services/ldap/settings.go

@@ -2,7 +2,7 @@ package ldap
 
 import (
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"sync"
 
 	"github.com/BurntSushi/toml"

pkg/services/live/live.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/services/live/pipeline/converter_json_auto_test.go

@@ -3,7 +3,7 @@ package pipeline
 import (
 	"context"
 	"flag"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"testing"
 	"time"

pkg/services/live/pipeline/storage_file.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 

pkg/services/live/telemetry/telegraf/convert_test.go

@@ -4,7 +4,7 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"testing"
 

pkg/services/ngalert/api/tooling/cmd/clean-swagger/main.go

@@ -3,7 +3,7 @@ package main
 import (
 	"encoding/json"
 	"flag"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"log"
 	"strings"
 )

pkg/services/ngalert/api/tooling/definitions/alertmanager_test.go

@@ -3,7 +3,7 @@ package definitions
 import (
 	"encoding/json"
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"strings"
 	"testing"
 

pkg/services/ngalert/eval/eval.go

@@ -531,6 +531,7 @@ func (evalResults Results) AsDataFrame() data.Frame {
 		labelColumns = append(labelColumns, k)
 	}
 
+	//nolint:staticcheck
 	labelColumns = sort.StringSlice(labelColumns)
 
 	frame := data.NewFrame("evaluation results")

pkg/services/ngalert/notifier/channels/default_template.go

@@ -1,7 +1,7 @@
 package channels
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"testing"
 

pkg/services/ngalert/notifier/channels/default_template_test.go

@@ -2,7 +2,7 @@ package channels
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/url"
 	"os"
 	"testing"

pkg/services/ngalert/notifier/channels/teams_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"strings"

pkg/services/ngalert/notifier/config.go

@@ -3,7 +3,7 @@ package notifier
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 

pkg/services/ngalert/notifier/config_test.go

@@ -2,7 +2,7 @@ package notifier
 
 import (
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"testing"
 

pkg/services/ngalert/notifier/file_store_test.go

@@ -2,7 +2,7 @@ package notifier
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"testing"

pkg/services/ngalert/notifier/multiorg_alertmanager.go

@@ -3,7 +3,7 @@ package notifier
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"path/filepath"
 	"strconv"
 	"sync"

pkg/services/ngalert/schedule/schedule_test.go

@@ -253,7 +253,7 @@ func assertEvalRun(t *testing.T, ch <-chan evalAppliedInfo, tick time.Time, keys
 		case info := <-ch:
 			_, ok := expected[info.alertDefKey]
 			if !ok {
-				t.Fatal(fmt.Sprintf("alert rule: %v should not have been evaluated at: %v", info.alertDefKey, info.now))
+				t.Fatalf("alert rule: %v should not have been evaluated at: %v", info.alertDefKey, info.now)
 			}
 			t.Logf("alert rule: %v evaluated at: %v", info.alertDefKey, info.now)
 			assert.Equal(t, tick, info.now)

pkg/services/ngalert/store/testing.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"math/rand"
 	"net/http"
 	"net/http/httptest"

pkg/services/notifications/send_email_integration_test.go

@@ -2,7 +2,7 @@ package notifications
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"testing"
 
 	"github.com/grafana/grafana/pkg/bus"

pkg/services/notifications/webhook.go

@@ -5,7 +5,7 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net"
 	"net/http"
 	"time"

pkg/services/provisioning/dashboards/config_reader.go

@@ -3,7 +3,7 @@ package dashboards
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/services/provisioning/dashboards/file_reader.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/services/provisioning/datasources/config_reader.go

@@ -3,7 +3,7 @@ package datasources
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/services/provisioning/notifiers/config_reader.go

@@ -3,7 +3,7 @@ package notifiers
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/services/provisioning/plugins/config_reader.go

@@ -3,7 +3,7 @@ package plugins
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"path/filepath"
 	"strings"

pkg/services/provisioning/values/values_test.go

@@ -3,7 +3,7 @@ package values
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"testing"
 

pkg/services/rendering/http_mode.go

@@ -173,6 +173,8 @@ func (rs *RenderingService) readFileResponse(ctx context.Context, resp *http.Res
 			resp.Status)
 	}
 
+	// Path comes from configuration.
+	//nolint:gosec
 	out, err := os.Create(filePath)
 	if err != nil {
 		return err

pkg/services/searchV2/extract/dashboard_test.go

@@ -50,6 +50,7 @@ func TestReadDashboard(t *testing.T) {
 
 		update := false
 		savedPath := "testdata/" + input + "-info.json"
+		//nolint:gosec
 		saved, err := os.ReadFile(savedPath)
 		if err != nil {
 			update = true

pkg/services/sqlstore/migrations/accesscontrol/permission_migrator.go

@@ -94,6 +94,7 @@ func (m *permissionMigrator) bulkAssignRoles(allRoles []*accesscontrol.Role) err
 				Created: ts,
 			})
 		} else if strings.HasPrefix(role.Name, "managed:builtins") {
+			//nolint:staticcheck
 			builtIn := strings.Title(strings.Split(role.Name, ":")[2])
 			builtInRoleAssignments = append(builtInRoleAssignments, accesscontrol.BuiltinRole{
 				OrgID:   role.OrgID,

pkg/services/sqlstore/migrations/ualert/silences.go

@@ -199,6 +199,7 @@ func openReplace(filename string) (*replaceFile, error) {
 		return nil, err
 	}
 
+	//nolint:gosec
 	f, err := os.Create(tmpFilename)
 	if err != nil {
 		return nil, err

pkg/services/sqlstore/tls_mysql.go

@@ -4,7 +4,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 
 	"github.com/grafana/grafana/pkg/infra/log"
 )

pkg/services/thumbs/service.go

@@ -5,7 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"time"
 
 	"github.com/grafana/grafana/pkg/api/response"

pkg/services/updatechecker/grafana.go

@@ -3,7 +3,7 @@ package updatechecker
 import (
 	"context"
 	"encoding/json"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 	"sync"