Chore: Upgrade Go to 1.19.2 (#56857)

We also need to upgrade the linter together with the Go version, all the changes should relate to either fixing linting problems or upgrading the Go version used to build Grafana.

pkg/api/alerting.go

@@ -553,7 +553,7 @@ func (hs *HTTPServer) PauseAlert(c *models.ReqContext) response.Response {
 		return response.Error(500, "", err)
 	}
 
-	var resp models.AlertStateType = models.AlertStateUnknown
+	var resp = models.AlertStateUnknown
 	pausedState := "un-paused"
 	if cmd.Paused {
 		resp = models.AlertStatePaused
@@ -579,7 +579,7 @@ func (hs *HTTPServer) PauseAllAlerts(c *models.ReqContext) response.Response {
 		return response.Error(500, "Failed to pause alerts", err)
 	}
 
-	var resp models.AlertStateType = models.AlertStatePending
+	var resp = models.AlertStatePending
 	pausedState := "un paused"
 	if updateCmd.Paused {
 		resp = models.AlertStatePaused

pkg/api/avatar/avatar.go

@@ -11,7 +11,7 @@ import (
 	"bytes"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"path/filepath"

pkg/api/dashboard_test.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/docs/merge/merge_specs.go

@@ -6,7 +6,7 @@ import (
 	"encoding/json"
 	"flag"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"os"
 	"strings"
 
@@ -84,6 +84,7 @@ func mergeSpecs(output string, sources ...string) error {
 		return fmt.Errorf("failed to intend new spec: %w", err)
 	}
 
+	//nolint:gosec
 	f, err = os.Create(output)
 	if err != nil {
 		return fmt.Errorf("failed to create file for new spec: %w", err)

pkg/api/frontend_logging_test.go

@@ -2,7 +2,7 @@ package api
 
 import (
 	"errors"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/url"
 	"os"
 	"strings"

pkg/api/frontendlogging/source_maps.go

@@ -1,7 +1,7 @@
 package frontendlogging
 
 import (
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/api/login_test.go

@@ -7,7 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"strings"

pkg/api/plugin_dashboards_test.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/plugin_metrics_test.go

@@ -2,7 +2,7 @@ package api
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"testing"
 

pkg/api/pluginproxy/ds_proxy.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"strconv"

pkg/api/pluginproxy/ds_proxy_test.go

@@ -4,7 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"net/url"

pkg/api/pluginproxy/pluginproxy.go

@@ -3,7 +3,7 @@ package pluginproxy
 import (
 	"bytes"
 	"encoding/json"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httputil"
 	"net/url"

pkg/api/pluginproxy/pluginproxy_test.go

@@ -2,7 +2,7 @@ package pluginproxy
 
 import (
 	"context"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"testing"

pkg/api/pluginproxy/utils.go

@@ -3,7 +3,7 @@ package pluginproxy
 import (
 	"bytes"
 	"fmt"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"strings"
 	"text/template"

pkg/api/plugins.go

@@ -6,7 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/url"
 	"os"

pkg/api/plugins_test.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"io/ioutil"
+	"io/ioutil"  //nolint:staticcheck // No need to change in v8.
 	"net/http"
 	"net/http/httptest"
 	"os"