public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove unused authorization helper functions

Browse Source 
Remove allowForAdminsOrAccessPolicy and allowForViewersOrAccessPolicy
as they are no longer used after refactoring to use authorizeRoleBasedResource.
This commit is contained in:
Roberto Jimenez Sanchez
2025-12-18 10:28:01 +01:00
parent 67cdf21096
commit 669bbca346
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/registry/apis/provisioning/register.go
-16
View File
@@ -502,22 +502,6 @@ func toAuthorizerDecision(err error) (authorizer.Decision, string, error) {
return authorizer.DecisionAllow, "", nil
}
// allowForAdminsOrAccessPolicy is used for resources without fine-grained permissions.
func allowForAdminsOrAccessPolicy(id identity.Requester) (authorizer.Decision, string, error) {
if authlib.IsIdentityType(id.GetIdentityType(), authlib.TypeAccessPolicy) || id.GetOrgRole().Includes(identity.RoleAdmin) {
return authorizer.DecisionAllow, "", nil
}
return authorizer.DecisionDeny, "admin role is required", nil
}
// allowForViewersOrAccessPolicy allows any authenticated user with at least viewer role.
func allowForViewersOrAccessPolicy(id identity.Requester) (authorizer.Decision, string, error) {
if authlib.IsIdentityType(id.GetIdentityType(), authlib.TypeAccessPolicy) || id.GetOrgRole().Includes(identity.RoleViewer) {
return authorizer.DecisionAllow, "", nil
}
return authorizer.DecisionDeny, "viewer role is required", nil
}
// isRoleBasedResource returns true for resources that use role-based authorization
// instead of fine-grained permissions. These resources bypass the access checker.
func isRoleBasedResource(resource string) bool {