[v10.4.x] Google Cloud Monitor: Fix res being accessed after it becomes nil in promql_query.go (#85959)
Google Cloud Monitor: Fix `res` being accessed after it becomes `nil` in `promql_query.go` (#84223)
Fix res being accessed after it becomes nil in promql_query.go
(cherry picked from commit c2b94429e4)
Co-authored-by: Adam Yeats <16296989+adamyeats@users.noreply.github.com>
This commit is contained in:
co-authored by
Adam Yeats
parent
d922afa346
commit
701c851be7
@@ -42,15 +42,16 @@ func (promQLQ *cloudMonitoringProm) run(ctx context.Context, req *backend.QueryD
|
||||
}
|
||||
|
||||
res, err := doRequestProm(r, dsInfo, requestBody)
|
||||
if err != nil {
|
||||
dr.Error = err
|
||||
return dr, promResponse{}, "", nil
|
||||
}
|
||||
|
||||
defer func() {
|
||||
if err := res.Body.Close(); err != nil {
|
||||
s.logger.Error("Failed to close response body", "err", err)
|
||||
}
|
||||
}()
|
||||
if err != nil {
|
||||
dr.Error = err
|
||||
return dr, promResponse{}, "", nil
|
||||
}
|
||||
|
||||
return dr, parseProm(res), r.URL.RawQuery, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user