API: Add theme validation (#38432) (#38480)

* Add theme validation

* Fix lint for const

(cherry picked from commit ccab9611cb)

Co-authored-by: idafurjes <36131195+idafurjes@users.noreply.github.com>

pkg/api/preferences.go

@@ -7,6 +7,12 @@ import (
 	"github.com/grafana/grafana/pkg/models"
 )
 
+const (
+	defaultTheme string = ""
+	darkTheme    string = "dark"
+	lightTheme   string = "light"
+)
+
 // POST /api/preferences/set-home-dash
 func SetHomeDashboard(c *models.ReqContext, cmd models.SavePreferencesCommand) response.Response {
 	cmd.UserId = c.UserId
@@ -46,6 +52,9 @@ func UpdateUserPreferences(c *models.ReqContext, dtoCmd dtos.UpdatePrefsCmd) res
 }
 
 func updatePreferencesFor(orgID, userID, teamId int64, dtoCmd *dtos.UpdatePrefsCmd) response.Response {
+	if dtoCmd.Theme != lightTheme && dtoCmd.Theme != darkTheme && dtoCmd.Theme != defaultTheme {
+		return response.Error(400, "Invalid theme", nil)
+	}
 	saveCmd := models.SavePreferencesCommand{
 		UserId:          userID,
 		OrgId:           orgID,