refactor: fix displayname and description for serviceaccount role (#41946) (#41962)

* refactor: fix displayname and description for serviceaccount role

* add: ActionWrite, ActionCreate

* refactor: update description

(cherry picked from commit 253da4a936)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>

pkg/services/serviceaccounts/manager/roles.go

@@ -8,11 +8,19 @@ import (
 var (
 	role = accesscontrol.RoleRegistration{
 		Role: accesscontrol.RoleDTO{
-			Version:     2,
+			Version:     3,
 			Name:        "fixed:serviceaccounts:writer",
-			Description: "",
+			DisplayName: "Service accounts writer",
+			Description: "Create, delete, read, or query service accounts.",
 			Group:       "Service accounts",
 			Permissions: []accesscontrol.Permission{
+				{
+					Action: serviceaccounts.ActionRead,
+					Scope:  serviceaccounts.ScopeAll,
+				},
+				{
+					Action: serviceaccounts.ActionCreate,
+				},
 				{
 					Action: serviceaccounts.ActionDelete,
 					Scope:  serviceaccounts.ScopeAll,

pkg/services/serviceaccounts/models.go

@@ -8,5 +8,8 @@ var (
 )
 
 const (
+	ActionRead   = "serviceaccounts:read"
+	ActionWrite  = "serviceaccounts:write"
+	ActionCreate = "serviceaccounts:create"
 	ActionDelete = "serviceaccounts:delete"
 )