public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove panel selection during drag that opens edit pane

Browse Source 
The code was selecting the panel after the drag distance threshold was reached,
which caused the edit pane to open during dragging. This was unintended behavior.
This commit is contained in:
oscarkilhed
2026-01-08 09:31:11 +01:00
parent 7ea4dd3744
commit 792a26800b
1 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/dashboard-scene/scene/DashboardLayoutOrchestrator.tsx
+1 -15
View File
@@ -13,7 +13,7 @@ import {
VizPanel,
SceneGridItemLike,
} from '@grafana/scenes';
import { createPointerDistance, useStyles2 } from '@grafana/ui';
import { useStyles2 } from '@grafana/ui';
import { DashboardScene } from './DashboardScene';
import { AutoGridLayoutManager } from './layout-auto-grid/AutoGridLayoutManager';
@@ -53,8 +53,6 @@ export class DashboardLayoutOrchestrator extends SceneObjectBase<DashboardLayout
private _sourceDropTarget: DashboardDropTarget | null = null;
private _lastDropTarget: DashboardDropTarget | null = null;
private _pointerDistance = createPointerDistance();
private _isSelectedObject = false;
private _tabActivationTimer: ReturnType<typeof setTimeout> | null = null;
private _lastHoveredTabKey: string | null = null;
/** Track if item was detached from source during cross-tab drag */
@@ -117,9 +115,6 @@ export class DashboardLayoutOrchestrator extends SceneObjectBase<DashboardLayout
}
public startDraggingSync(evt: ReactPointerEvent, gridItem: SceneGridItemLike): void {
this._pointerDistance.set(evt);
this._isSelectedObject = false;
const dropTarget = sceneGraph.findObject(gridItem, isDashboardDropTarget);
if (!dropTarget || !isDashboardDropTarget(dropTarget)) {
@@ -575,15 +570,6 @@ export class DashboardLayoutOrchestrator extends SceneObjectBase<DashboardLayout
this._lastCursorX = evt.clientX;
this._lastCursorY = evt.clientY;
if (!this._isSelectedObject && this.state.draggingGridItem && this._pointerDistance.check(evt)) {
this._isSelectedObject = true;
const gridItem = this.state.draggingGridItem?.resolve();
if (gridItem && 'state' in gridItem && 'body' in gridItem.state && gridItem.state.body instanceof VizPanel) {
const panel = gridItem.state.body;
this._getDashboard().state.editPane.selectObject(panel, panel.state.key!, { force: true, multi: false });
}
}
// Check for tab hover to enable tab switching during drag
this._checkTabHover(evt.clientX, evt.clientY);