fix: Remove legacy title-prop and update document.title when navModel is changed #15108

This commit is contained in:
Johannes Schill
2019-01-29 17:03:40 +01:00
parent 365de9de20
commit 7d8607c1b3
+2 -2
View File
@@ -9,9 +9,9 @@ import PageHeader from '../PageHeader/PageHeader';
import Footer from '../Footer/Footer';
import PageContents from './PageContents';
import { CustomScrollbar } from '@grafana/ui';
import { isEqual } from 'lodash';
interface Props {
title?: string;
children: JSX.Element[] | JSX.Element;
navModel: NavModel;
}
@@ -28,7 +28,7 @@ class Page extends Component<Props> {
}
componentDidUpdate(prevProps: Props) {
if (prevProps.title !== this.props.title) {
if (!isEqual(prevProps.navModel, this.props.navModel)) {
this.updateTitle();
}
}