InlineSecureValue: Add owner API group to decrypters list (#109241)

This commit is contained in:
Matheus Macabu
2025-08-06 12:00:00 +02:00
committed by GitHub
parent c9daccfd28
commit 7e09f75100
2 changed files with 12 additions and 2 deletions
@@ -209,6 +209,7 @@ func (s *LocalInlineSecureValueService) CreateInline(ctx context.Context, owner
Value: &secret,
Decrypters: []string{
serviceIdentity,
owner.APIGroup,
},
},
}
@@ -242,7 +242,8 @@ func TestIntegration_InlineSecureValue_CreateInline(t *testing.T) {
tu := testutils.Setup(t)
secret := common.NewSecretValue("test-value")
rawSecret := "test-value"
secret := common.NewSecretValue(rawSecret)
serviceIdentity := "service-identity"
@@ -259,7 +260,15 @@ func TestIntegration_InlineSecureValue_CreateInline(t *testing.T) {
decryptedResult, ok := decryptedValues[createdName]
require.True(t, ok)
require.Equal(t, decryptedResult.Value().DangerouslyExposeAndConsumeValue(), secret.DangerouslyExposeAndConsumeValue())
require.Equal(t, decryptedResult.Value().DangerouslyExposeAndConsumeValue(), rawSecret)
// can also decrypt with the owner.APIGroup as a decrypter
decryptedValues, err = tu.DecryptService.Decrypt(t.Context(), owner.APIGroup, owner.Namespace, []string{createdName})
require.NoError(t, err)
decryptedResult, ok = decryptedValues[createdName]
require.True(t, ok)
require.Equal(t, decryptedResult.Value().DangerouslyExposeAndConsumeValue(), rawSecret)
})
t.Run("when the auth info is missing it returns an error", func(t *testing.T) {