public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Correctly persist FiredAt in SyncRuleStatePersister (#106658)

Browse Source 
Correctly persist FiredAt
This commit is contained in:
Fayzal Ghantiwala
2025-06-12 18:07:16 +01:00
committed by GitHub
parent e0d27dc0d7
commit 85df859589
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/ngalert/state/persister_sync_rule.go
+1
View File
@@ -53,6 +53,7 @@ func (a *SyncRuleStatePersister) Sync(ctx context.Context, span trace.Span, rule
LastEvalTime: s.LastEvaluationTime,
CurrentStateSince: s.StartsAt,
CurrentStateEnd: s.EndsAt,
FiredAt: s.FiredAt,
ResolvedAt: s.ResolvedAt,
LastSentAt: s.LastSentAt,
ResultFingerprint: s.ResultFingerprint.String(),
pkg/services/ngalert/state/persister_sync_rule_test.go
+3
View File
@@ -11,6 +11,7 @@ import (
"github.com/grafana/grafana-plugin-sdk-go/data"
"github.com/grafana/grafana/pkg/infra/log"
"github.com/grafana/grafana/pkg/services/ngalert/models"
"github.com/grafana/grafana/pkg/util"
)
func TestSyncRuleStatePersister_Sync(t *testing.T) {
@@ -33,6 +34,7 @@ func TestSyncRuleStatePersister_Sync(t *testing.T) {
Labels: data.Labels{
"label-1": "value-1",
},
FiredAt: util.Pointer(time.Now()),
LastEvaluationTime: time.Now(),
StartsAt: time.Now(),
EndsAt: time.Now(),
@@ -72,6 +74,7 @@ func TestSyncRuleStatePersister_Sync(t *testing.T) {
LastEvalTime: s.LastEvaluationTime,
CurrentStateSince: s.StartsAt,
CurrentStateEnd: s.EndsAt,
FiredAt: s.FiredAt,
ResolvedAt: s.ResolvedAt,
LastSentAt: s.LastSentAt,
ResultFingerprint: s.ResultFingerprint.String(),