Palette: use semi-dark-yellow for more contrast (#112090)

* use semi-dark-yellow for more contrast

* fix unit tests

packages/grafana-data/src/field/fieldColor.test.ts

@@ -47,7 +47,7 @@ describe('fieldColorModeRegistry', () => {
 
   it('Palette classic with series index 1', () => {
     const calcFn = getCalculator({ mode: FieldColorModeId.PaletteClassic, seriesIndex: 1, name: 'series2' });
-    expect(calcFn(70, 0, undefined)).toEqual('#FADE2A');
+    expect(calcFn(70, 0, undefined)).toEqual('#F2CC0C');
   });
 
   it('Palette uses name', () => {

packages/grafana-data/src/field/fieldDisplay.test.ts

@@ -388,7 +388,7 @@ describe('FieldDisplay', () => {
 
       const result = getFieldDisplayValues(options);
       expect(result[0].display.color).toEqual('#73BF69');
-      expect(result[1].display.color).toEqual('#FADE2A');
+      expect(result[1].display.color).toEqual('#F2CC0C');
     });
 
     it('When showing all values lookup color via an override', () => {
@@ -435,7 +435,7 @@ describe('FieldDisplay', () => {
 
       const result = getFieldDisplayValues(options);
       expect(result[0].display.color).toEqual('#AAA');
-      expect(result[1].display.color).toEqual('#FADE2A');
+      expect(result[1].display.color).toEqual('#F2CC0C');
     });
 
     it('Multiple other string fields', () => {

packages/grafana-data/src/themes/createVisualizationColors.ts

@@ -261,7 +261,7 @@ function getClassicPalette() {
 
   return [
     'green',
-    'yellow',
+    'semi-dark-yellow',
     'blue',
     'orange',
     'red',