datasources: querier: add unit tests (#107105)

2025-06-24 13:07:05 +02:00
parent a88e06a647
commit 8ba6487b15
1 changed files with 85 additions and 0 deletions
@@ -67,6 +67,91 @@ func TestQuerySplitting(t *testing.T) {
 		require.Equal(t, "0", split.Requests[0].Request.From)
 		require.Equal(t, "0", split.Requests[0].Request.To)
 	})
+
+	t.Run("forbid duplicate refId", func(t *testing.T) {
+		_, err := parser.parseRequest(ctx, &query.QueryDataRequest{
+			QueryDataRequest: data.QueryDataRequest{
+				TimeRange: data.TimeRange{},
+				Queries: []data.DataQuery{
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "A",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "A",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+				},
+			},
+		})
+		require.Error(t, err)
+	})
+	t.Run("forbid duplicate refId, when refId=''", func(t *testing.T) {
+		_, err := parser.parseRequest(ctx, &query.QueryDataRequest{
+			QueryDataRequest: data.QueryDataRequest{
+				TimeRange: data.TimeRange{},
+				Queries: []data.DataQuery{
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+				},
+			},
+		})
+		require.Error(t, err)
+	})
+	t.Run("allow empty refId", func(t *testing.T) {
+		_, err := parser.parseRequest(ctx, &query.QueryDataRequest{
+			QueryDataRequest: data.QueryDataRequest{
+				TimeRange: data.TimeRange{},
+				Queries: []data.DataQuery{
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+					{
+						CommonQueryProperties: data.CommonQueryProperties{
+							RefID: "B",
+							Datasource: &data.DataSourceRef{
+								Type: "x",
+								UID:  "abc",
+							},
+						},
+					},
+				},
+			},
+		})
+		require.NoError(t, err)
+	})
 	t.Run("applies query time range if present", func(t *testing.T) {
 		split, err := parser.parseRequest(ctx, &query.QueryDataRequest{
 			QueryDataRequest: data.QueryDataRequest{