public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Canvas: Improve resource picker initialization (#57319) (#57566)

Browse Source 
(cherry picked from commit 9d857f4d61)

Co-authored-by: Nathan Marrs <nathanielmarrs@gmail.com>
This commit is contained in:
Grot (@grafanabot)
2022-10-24 16:52:40 -04:00
committed by GitHub
co-authored by Nathan Marrs
parent 8ea7a8cff3
commit 92fa1aba00
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.betterer.results
+1 -2
View File
@@ -4230,8 +4230,7 @@ exports[`better eslint`] = {
],
"public/app/features/dimensions/editors/ResourceDimensionEditor.tsx:5381": [
[0, 0, 0, "Do not use any type assertions.", "0"],
[0, 0, 0, "Unexpected any. Specify a different type.", "1"],
[0, 0, 0, "Unexpected any. Specify a different type.", "2"]
[0, 0, 0, "Unexpected any. Specify a different type.", "1"]
],
"public/app/features/dimensions/editors/ResourcePicker.tsx:5381": [
[0, 0, 0, "Unexpected any. Specify a different type.", "0"]
public/app/features/dimensions/editors/ResourceDimensionEditor.tsx
+4 -4
View File
@@ -1,4 +1,4 @@
import React, { FC, useCallback } from 'react';
import React, { useCallback } from 'react';
import { FieldNamePickerConfigSettings, StandardEditorProps, StandardEditorsRegistryItem } from '@grafana/data';
import { InlineField, InlineFieldRow, RadioButtonGroup } from '@grafana/ui';
@@ -25,9 +25,9 @@ const dummyFieldSettings: StandardEditorsRegistryItem<string, FieldNamePickerCon
settings: {},
} as any;
export const ResourceDimensionEditor: FC<
StandardEditorProps<ResourceDimensionConfig, ResourceDimensionOptions, any>
> = (props) => {
export const ResourceDimensionEditor = (
props: StandardEditorProps<ResourceDimensionConfig, ResourceDimensionOptions, unknown>
) => {
const { value, context, onChange, item } = props;
const labelWidth = 9;
public/app/features/dimensions/editors/ResourcePickerPopover.tsx
+2 -1
View File
@@ -37,8 +37,9 @@ export const ResourcePickerPopover = (props: Props) => {
const { dialogProps } = useDialog({}, ref);
const { overlayProps } = useOverlay({ onClose, isDismissable: true, isOpen: true }, ref);
const isURL = value && value.includes('://');
const [newValue, setNewValue] = useState<string>(value ?? '');
const [activePicker, setActivePicker] = useState<PickerTabType>(PickerTabType.Folder);
const [activePicker, setActivePicker] = useState<PickerTabType>(isURL ? PickerTabType.URL : PickerTabType.Folder);
const [formData, setFormData] = useState<FormData>(new FormData());
const [upload, setUpload] = useState<boolean>(false);
const [error, setError] = useState<ErrorResponse>({ message: '' });