public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Loki: Fix error when changing operations with different parameters (#51779) (#51820)

Browse Source 
* copy defaultParams when changing an operation

* add type and name comparison

* removed name check

(cherry picked from commit 663f3fcd2a)

Co-authored-by: Sven Grossmann <Svennergr@gmail.com>
This commit is contained in:
Grot (@grafanabot)
2022-07-06 17:19:10 +02:00
committed by GitHub
co-authored by Sven Grossmann
parent 8c2a855dee
commit 98b3d1e7b6
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/plugins/datasource/prometheus/querybuilder/shared/OperationHeader.tsx
+10 -1
View File
@@ -79,7 +79,16 @@ export const OperationHeader = React.memo<Props>(
if (value.value) {
// Operation should exist if it is selectable
const newDef = queryModeller.getOperationDef(value.value.id)!;
let changedOp = { ...operation, id: value.value.id };
// copy default params, and override with all current params
const newParams = [...newDef.defaultParams];
for (let i = 0; i < Math.min(operation.params.length, newParams.length); i++) {
if (newDef.params[i].type === def.params[i].type) {
newParams[i] = operation.params[i];
}
}
const changedOp = { ...operation, params: newParams, id: value.value.id };
onChange(index, def.changeTypeHandler ? def.changeTypeHandler(changedOp, newDef) : changedOp);
}
}}