public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CodeEditor: Trigger the lastest getSuggestions() passed to CodeEditor (#40544)

Browse Source
This commit is contained in:
Duke Manh
2021-10-18 12:36:13 +02:00
committed by GitHub
parent 1f44023ebe
commit 9eccb8e416
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/grafana-ui/src/components/Monaco/CodeEditor.tsx
+6 -1
View File
@@ -31,7 +31,10 @@ class UnthemedCodeEditor extends React.PureComponent<Props> {
componentDidUpdate(oldProps: Props) {
const { getSuggestions, language } = this.props;
if (language !== oldProps.language) {
const newLanguage = oldProps.language !== language;
const newGetSuggestions = oldProps.getSuggestions !== getSuggestions;
if (newGetSuggestions || newLanguage) {
if (this.completionCancel) {
this.completionCancel.dispose();
}
@@ -44,7 +47,9 @@ class UnthemedCodeEditor extends React.PureComponent<Props> {
if (getSuggestions) {
this.completionCancel = registerSuggestions(this.monaco, language, getSuggestions);
}
}
if (newLanguage) {
this.loadCustomLanguage();
}
}