public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dynamic Dashboards: Make outline open by default (#114146)

Browse Source
This commit is contained in:
Ida Štambuk
2025-11-20 12:37:12 +01:00
committed by GitHub
parent e9116cd23c
commit b2f022fb5e
8 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-playwright/dashboard-new-layouts/dashboard-outline.spec.ts
-2
View File
@@ -22,8 +22,6 @@ test.describe(
await dashboardPage.getByGrafanaSelector(selectors.components.NavToolbar.editDashboard.editButton).click();
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.section).click();
// Should be able to click Variables item in outline to see add variable button
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.item('Variables')).click();
await expect(
e2e-playwright/dashboard-new-layouts/dashboards-edit-custom-variables.spec.ts
-1
View File
@@ -199,7 +199,6 @@ test.describe(
.click();
// Open the modal editor in the side pane
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.section).click();
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.node('Variables')).click();
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.item('foo')).click();
await openModal(dashboardPage, selectors);
e2e-playwright/dashboard-new-layouts/utils.ts
-1
View File
@@ -48,7 +48,6 @@ export const flows = {
},
async newEditPaneVariableClick(dashboardPage: DashboardPage, selectors: E2ESelectorGroups) {
await dashboardPage.getByGrafanaSelector(selectors.components.NavToolbar.editDashboard.editButton).click();
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.section).click();
await dashboardPage.getByGrafanaSelector(selectors.components.PanelEditor.Outline.item('Variables')).click();
await dashboardPage
.getByGrafanaSelector(selectors.components.PanelEditor.ElementEditPane.addVariableButton)
public/app/features/dashboard-scene/edit-pane/DashboardEditPaneRenderer.tsx
+1 -1
View File
@@ -35,7 +35,7 @@ export function DashboardEditPaneRenderer({ editPane, isEditPaneCollapsed, onTog
const isNewElement = selection?.isNewElement() ?? false;
const [outlineCollapsed, setOutlineCollapsed] = useLocalStorage(
'grafana.dashboard.edit-pane.outline.collapsed',
true
false
);
const [outlinePaneSize = 0.4, setOutlinePaneSize] = useLocalStorage('grafana.dashboard.edit-pane.outline.size', 0.4);
public/app/features/dashboard-scene/scene/NavToolbarActions.test.tsx
+1 -1
View File
@@ -162,7 +162,7 @@ describe('NavToolbarActions', () => {
await userEvent.click(await screen.findByTestId(selectors.components.NavToolbar.editDashboard.editButton));
expect(DashboardInteractions.editButtonClicked).toHaveBeenCalledWith({
dashboardUid: 'dash-1',
outlineExpanded: false,
outlineExpanded: true,
});
});
public/app/features/dashboard-scene/scene/new-toolbar/actions/EditDashboardSwitch.test.tsx
+1 -1
View File
@@ -58,7 +58,7 @@ describe('EditDashboardSwitch', () => {
it('should call DashboardInteractions.editButtonClicked with outlineExpanded:true if grafana.dashboard.edit-pane.outline.collapsed is undefined', async () => {
render(<EditDashboardSwitch dashboard={buildTestScene()} />);
await userEvent.click(await screen.findByTestId(selectors.components.NavToolbar.editDashboard.editButton));
expect(DashboardInteractions.editButtonClicked).toHaveBeenCalledWith({ outlineExpanded: false });
expect(DashboardInteractions.editButtonClicked).toHaveBeenCalledWith({ outlineExpanded: true });
});
it('should call DashboardInteractions.editButtonClicked with outlineExpanded:true if grafana.dashboard.edit-pane.outline.collapsed is false', async () => {
public/app/features/dashboard-scene/scene/new-toolbar/actions/MakeDashboardEditableButton.test.tsx
+1 -1
View File
@@ -59,7 +59,7 @@ describe('MakeDashboardEditableButton', () => {
it('should call DashboardInteractions.editButtonClicked with outlineExpanded:true if grafana.dashboard.edit-pane.outline.collapsed is undefined', async () => {
render(<MakeDashboardEditableButton dashboard={buildTestScene()} />);
await userEvent.click(await screen.findByTestId(selectors.components.NavToolbar.editDashboard.editButton));
expect(DashboardInteractions.editButtonClicked).toHaveBeenCalledWith({ outlineExpanded: false });
expect(DashboardInteractions.editButtonClicked).toHaveBeenCalledWith({ outlineExpanded: true });
});
it('should call DashboardInteractions.editButtonClicked with outlineExpanded:true if grafana.dashboard.edit-pane.outline.collapsed is false', async () => {
public/app/features/dashboard-scene/utils/tracking.ts
+1 -1
View File
@@ -46,7 +46,7 @@ export const trackDeleteDashboardElement = (element: EditableDashboardElementInf
export const trackDashboardSceneEditButtonClicked = (dashboardUid?: string) => {
DashboardInteractions.editButtonClicked({
outlineExpanded: !store.getBool('grafana.dashboard.edit-pane.outline.collapsed', true),
outlineExpanded: !store.getBool('grafana.dashboard.edit-pane.outline.collapsed', false),
dashboardUid,
});
};