public/grafana
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove unnecessary rollback call

Browse Source
This commit is contained in:
Michael Mandrus committed 2022-06-10 13:58:54 -04:00
1 parent 6020bd1891
commit c01484a323
1 file changed
-3
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/sqlstore/datasource.go
-3
View File
@@ -118,7 +118,6 @@ func (ss *SQLStore) DeleteDataSource(ctx context.Context, cmd *models.DeleteData
if cmd.UpdateSecretFn != nil {
if err := cmd.UpdateSecretFn(); err != nil {
sess.Rollback()
sqlog.Error("Failed to update datasource secrets -- rolling back update", "UID", cmd.UID, "name", cmd.Name, "orgId", cmd.OrgID)
return err
}
@@ -191,7 +190,6 @@ func (ss *SQLStore) AddDataSource(ctx context.Context, cmd *models.AddDataSource
if cmd.UpdateSecretFn != nil {
if err := cmd.UpdateSecretFn(); err != nil {
sess.Rollback()
sqlog.Error("Failed to update datasource secrets -- rolling back update", "name", cmd.Name, "type", cmd.Type, "orgId", cmd.OrgId)
return err
}
@@ -281,7 +279,6 @@ func (ss *SQLStore) UpdateDataSource(ctx context.Context, cmd *models.UpdateData
if cmd.UpdateSecretFn != nil {
if err := cmd.UpdateSecretFn(); err != nil {
sess.Rollback()
sqlog.Error("Failed to update datasource secrets -- rolling back update", "UID", cmd.Uid, "name", cmd.Name, "type", cmd.Type, "orgId", cmd.OrgId)
return err
}