Alerting: Prevent routing preview from auto-triggering on mount (#113749)
* Alerting: Prevent routing preview from auto-triggering on mount * resolve PR comments * add info on hover of preview routing when disabled
This commit is contained in:
+19
-5
@@ -4,7 +4,7 @@ import { useEffectOnce } from 'react-use';
|
||||
|
||||
import { GrafanaTheme2 } from '@grafana/data';
|
||||
import { Trans, t } from '@grafana/i18n';
|
||||
import { Button, LoadingPlaceholder, Stack, Text, useStyles2 } from '@grafana/ui';
|
||||
import { Button, LoadingPlaceholder, Stack, Text, Tooltip, useStyles2 } from '@grafana/ui';
|
||||
import { alertRuleApi } from 'app/features/alerting/unified/api/alertRuleApi';
|
||||
import { AlertQuery, Labels } from 'app/types/unified-alerting-dto';
|
||||
|
||||
@@ -67,7 +67,9 @@ export const NotificationPreview = ({
|
||||
};
|
||||
|
||||
useEffectOnce(() => {
|
||||
onPreview();
|
||||
if (!disabled) {
|
||||
onPreview();
|
||||
}
|
||||
});
|
||||
|
||||
// Get alert managers's data source information
|
||||
@@ -102,9 +104,21 @@ export const NotificationPreview = ({
|
||||
</Text>
|
||||
)}
|
||||
</Stack>
|
||||
<Button icon="sync" variant="secondary" type="button" onClick={onPreview} disabled={disabled}>
|
||||
<Trans i18nKey="alerting.notification-preview.preview-routing">Preview routing</Trans>
|
||||
</Button>
|
||||
<Tooltip
|
||||
content={
|
||||
disabled ? (
|
||||
<Trans i18nKey="alerting.notification-preview.disabled-tooltip">
|
||||
You don't have sufficient permissions to preview
|
||||
</Trans>
|
||||
) : (
|
||||
''
|
||||
)
|
||||
}
|
||||
>
|
||||
<Button icon="sync" variant="secondary" type="button" onClick={onPreview} disabled={disabled}>
|
||||
<Trans i18nKey="alerting.notification-preview.preview-routing">Preview routing</Trans>
|
||||
</Button>
|
||||
</Tooltip>
|
||||
</Stack>
|
||||
{potentialInstances.length > 0 && (
|
||||
<Suspense
|
||||
|
||||
@@ -1982,6 +1982,7 @@
|
||||
},
|
||||
"notification-preview": {
|
||||
"alertmanager": "Alertmanager:",
|
||||
"disabled-tooltip": "You don't have sufficient permissions to preview",
|
||||
"error": "Could not load routing preview for {{alertmanager}}",
|
||||
"initialized": "Based on the labels added, alert instances are routed to the following notification policies. Expand each notification policy below to view more details.",
|
||||
"preview-routing": "Preview routing",
|
||||
|
||||
Reference in New Issue
Block a user