public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant tests

Browse Source
This commit is contained in:
Ivana
2020-03-13 10:59:56 +01:00
parent 300a43554f
commit e310bf144e
8 changed files with 12 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/explore/RichHistory/RichHistory.test.tsx
-3
View File
@@ -24,9 +24,6 @@ const setup = (propOverrides?: Partial<RichHistoryProps>) => {
};
describe('RichHistory', () => {
it('should render component without errors', () => {
setup();
});
it('should correctly render all tabs in tab bar', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('Query history');
public/app/features/explore/RichHistory/RichHistoryCard.test.tsx
-3
View File
@@ -40,9 +40,6 @@ const starredQueryWithComment = {
};
describe('RichHistoryCard', () => {
it('should render without errors', () => {
setup();
});
it('should render all queries', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('query1');
public/app/features/explore/RichHistory/RichHistoryCard.tsx
+1 -1
View File
@@ -117,7 +117,7 @@ export function RichHistoryCard(props: Props) {
<div className={styles.queryCardLeft} onClick={() => onChangeQuery(query)}>
{query.queries.map((q, i) => {
return (
<div title="query" key={`${q}-${i}`} className={styles.queryRow}>
<div key={`${q}-${i}`} className={styles.queryRow}>
{q}
</div>
);
public/app/features/explore/RichHistory/RichHistoryContainer.test.tsx
-3
View File
@@ -25,9 +25,6 @@ const setup = (propOverrides?: Partial<Props>) => {
};
describe('RichHistoryContainer', () => {
it('should render without errors', () => {
setup();
});
it('should render reseizable component', () => {
const wrapper = setup();
expect(wrapper.find(Resizable)).toHaveLength(1);
public/app/features/explore/RichHistory/RichHistoryQueriesTab.test.tsx
+3 -7
View File
@@ -25,14 +25,10 @@ const setup = (propOverrides?: Partial<Props>) => {
};
describe('RichHistoryQueriesTab', () => {
it('should render without errors', () => {
setup();
});
describe('slider', () => {
it('should render slider', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('aria-label="slider');
expect(wrapper.html()).toContain('aria-label="Slider');
});
it('should render slider with correct timerange', () => {
const wrapper = setup();
@@ -44,14 +40,14 @@ describe('RichHistoryQueriesTab', () => {
describe('sort options', () => {
it('should render sorter', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('aria-label="sort queries"');
expect(wrapper.html()).toContain('aria-label="Sort queries"');
});
});
describe('select datasource', () => {
it('should render select datasource if activeDatasourceOnly is false', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('aria-label="filter datasources"');
expect(wrapper.html()).toContain('aria-label="Filter datasources"');
});
it('should not render select datasource if activeDatasourceOnly is true', () => {
public/app/features/explore/RichHistory/RichHistoryQueriesTab.tsx
+3 -3
View File
@@ -162,7 +162,7 @@ export function RichHistoryQueriesTab(props: Props) {
return (
<div className={styles.container}>
<div className={styles.containerSlider}>
<div className={styles.slider} aria-label="slider">
<div className={styles.slider} aria-label="Slider">
<div className="label-slider">
Filter history <br />
between
@@ -187,7 +187,7 @@ export function RichHistoryQueriesTab(props: Props) {
<div className={styles.containerContent}>
<div className={styles.selectors}>
{!activeDatasourceOnly && (
<div className={styles.multiselect} aria-label="filter datasources">
<div className={styles.multiselect} aria-label="Filter datasources">
<Select
isMulti={true}
options={datasources}
@@ -197,7 +197,7 @@ export function RichHistoryQueriesTab(props: Props) {
/>
</div>
)}
<div className={styles.sort} aria-label="sort queries">
<div className={styles.sort} aria-label="Sort queries">
<Select
options={sortOrderOptions}
placeholder="Sort queries by"
public/app/features/explore/RichHistory/RichHistoryStarredTab.test.tsx
+3 -6
View File
@@ -24,25 +24,22 @@ const setup = (propOverrides?: Partial<Props>) => {
};
describe('RichHistoryStarredTab', () => {
it('should render without errors', () => {
setup();
});
describe('sorter', () => {
it('should render sorter', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('aria-label="sort queries"');
expect(wrapper.html()).toContain('aria-label="Sort queries"');
});
});
describe('select datasource', () => {
it('should render select datasource if activeDatasourceOnly is false', () => {
const wrapper = setup();
expect(wrapper.html()).toContain('aria-label="filter datasources"');
expect(wrapper.html()).toContain('aria-label="Filter datasources"');
});
it('should not render select datasource if activeDatasourceOnly is true', () => {
const wrapper = setup({ activeDatasourceOnly: true });
expect(wrapper.html()).not.toContain('aria-label="filter datasources"');
expect(wrapper.html()).not.toContain('aria-label="Filter datasources"');
});
});
});
public/app/features/explore/RichHistory/RichHistoryStarredTab.tsx
+2 -2
View File
@@ -111,7 +111,7 @@ export function RichHistoryStarredTab(props: Props) {
<div className={styles.containerContent}>
<div className={styles.selectors}>
{!activeDatasourceOnly && (
<div className={styles.multiselect} aria-label="filter datasources">
<div className={styles.multiselect} aria-label="Filter datasources">
<Select
isMulti={true}
options={exploreDatasources}
@@ -121,7 +121,7 @@ export function RichHistoryStarredTab(props: Props) {
/>
</div>
)}
<div className={styles.sort} aria-label="sort queries">
<div className={styles.sort} aria-label="Sort queries">
<Select
options={sortOrderOptions}
placeholder="Sort queries by"