RBAC: Remove sort and unique values when fetching permissions (#53461)

* RBAC: remove sort and unique values for fetching permissions
This commit is contained in:
Karl Persson
2022-08-09 15:52:14 +02:00
committed by GitHub
parent 27e2953951
commit e4c45c4f98
@@ -26,8 +26,7 @@ func (s *AccessControlStore) GetUserPermissions(ctx context.Context, query acces
err := s.sql.WithDbSession(ctx, func(sess *sqlstore.DBSession) error {
filter, params := userRolesFilter(query.OrgID, query.UserID, query.Roles)
// TODO: optimize this
q := `SELECT DISTINCT
q := `SELECT
permission.action,
permission.scope
FROM permission
@@ -45,10 +44,6 @@ func (s *AccessControlStore) GetUserPermissions(ctx context.Context, query acces
}
}
q += `
ORDER BY permission.scope
`
if err := sess.SQL(q, params...).Find(&result); err != nil {
return err
}