public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[v9.1.x] Alerting: Fix crash when viewing alert group without interval (#53188)

Browse Source 
Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
This commit is contained in:
Grot (@grafanabot)
2022-08-03 10:12:54 +02:00
committed by GitHub
co-authored by Gilles De Mey
parent 0015826410
commit f0aad29a63
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/alerting/unified/components/rules/RuleConfigStatus.tsx
+1 -1
View File
@@ -15,7 +15,7 @@ interface RuleConfigStatusProps {
export function RuleConfigStatus({ rule }: RuleConfigStatusProps) {
const styles = useStyles2(getStyles);
const { exceedsLimit } = checkEvaluationIntervalGlobalLimit(rule.group.interval ?? '');
const { exceedsLimit } = checkEvaluationIntervalGlobalLimit(rule.group.interval);
if (!exceedsLimit) {
return null;
public/app/features/alerting/unified/utils/config.ts
+5 -1
View File
@@ -5,7 +5,11 @@ export function getAllDataSources(): Array<DataSourceInstanceSettings<DataSource
return Object.values(config.datasources);
}
export function checkEvaluationIntervalGlobalLimit(alertGroupEvaluateEvery: string) {
export function checkEvaluationIntervalGlobalLimit(alertGroupEvaluateEvery?: string) {
if (!alertGroupEvaluateEvery) {
return { globalLimit: 0, exceedsLimit: false };
}
if (!isValidGoDuration(config.unifiedAlerting.minInterval)) {
return { globalLimit: 0, exceedsLimit: false };
}