AdHoc Filters in Tooltips: Remove feature toggle (#113695)
* Remove `dashboardDsAdHocFiltering` feature toggle From our feature toggles machinery only. Removing from our application code next. * Remove feature toggle from application code
This commit is contained in:
@@ -78,7 +78,6 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general-
|
||||
| `grafanaAssistantInProfilesDrilldown` | Enables integration with Grafana Assistant in Profiles Drilldown | Yes |
|
||||
| `sharingDashboardImage` | Enables image sharing functionality for dashboards | Yes |
|
||||
| `tabularNumbers` | Use fixed-width numbers globally in the UI | |
|
||||
| `adhocFiltersInTooltips` | Enable adhoc filter buttons in visualization tooltips | Yes |
|
||||
| `tempoSearchBackendMigration` | Run search queries through the tempo backend | |
|
||||
|
||||
## Public preview feature toggles
|
||||
|
||||
@@ -1127,11 +1127,6 @@ export interface FeatureToggles {
|
||||
*/
|
||||
restrictedPluginApis?: boolean;
|
||||
/**
|
||||
* Enable adhoc filter buttons in visualization tooltips
|
||||
* @default true
|
||||
*/
|
||||
adhocFiltersInTooltips?: boolean;
|
||||
/**
|
||||
* Enable favorite datasources
|
||||
*/
|
||||
favoriteDatasources?: boolean;
|
||||
|
||||
@@ -1959,14 +1959,6 @@ var (
|
||||
FrontendOnly: true,
|
||||
Expression: "false",
|
||||
},
|
||||
{
|
||||
Name: "adhocFiltersInTooltips",
|
||||
Description: "Enable adhoc filter buttons in visualization tooltips",
|
||||
Stage: FeatureStageGeneralAvailability,
|
||||
Owner: grafanaDataProSquad,
|
||||
FrontendOnly: true,
|
||||
Expression: "true",
|
||||
},
|
||||
{
|
||||
Name: "favoriteDatasources",
|
||||
Description: "Enable favorite datasources",
|
||||
|
||||
@@ -252,7 +252,6 @@ unifiedStorageSearchDualReaderEnabled,experimental,@grafana/search-and-storage,f
|
||||
dashboardLevelTimeMacros,experimental,@grafana/dashboards-squad,false,false,true
|
||||
alertmanagerRemoteSecondaryWithRemoteState,experimental,@grafana/alerting-squad,false,false,false
|
||||
restrictedPluginApis,experimental,@grafana/plugins-platform-backend,false,false,true
|
||||
adhocFiltersInTooltips,GA,@grafana/datapro,false,false,true
|
||||
favoriteDatasources,experimental,@grafana/plugins-platform-backend,false,false,true
|
||||
newLogContext,experimental,@grafana/observability-logs,false,false,true
|
||||
newClickhouseConfigPageDesign,privatePreview,@grafana/partner-datasources,false,false,false
|
||||
|
||||
|
Generated
-4
@@ -1018,10 +1018,6 @@ const (
|
||||
// Enables sharing a list of APIs with a list of plugins
|
||||
FlagRestrictedPluginApis = "restrictedPluginApis"
|
||||
|
||||
// FlagAdhocFiltersInTooltips
|
||||
// Enable adhoc filter buttons in visualization tooltips
|
||||
FlagAdhocFiltersInTooltips = "adhocFiltersInTooltips"
|
||||
|
||||
// FlagFavoriteDatasources
|
||||
// Enable favorite datasources
|
||||
FlagFavoriteDatasources = "favoriteDatasources"
|
||||
|
||||
@@ -25,6 +25,7 @@
|
||||
"name": "adhocFiltersInTooltips",
|
||||
"resourceVersion": "1756814786992",
|
||||
"creationTimestamp": "2025-07-29T17:53:43Z",
|
||||
"deletionTimestamp": "2025-11-11T09:49:48Z",
|
||||
"annotations": {
|
||||
"grafana.app/updatedTimestamp": "2025-09-02 12:06:26.992384 +0000 UTC"
|
||||
}
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { useMemo } from 'react';
|
||||
|
||||
import { PanelProps, VizOrientation } from '@grafana/data';
|
||||
import { config, PanelDataErrorView } from '@grafana/runtime';
|
||||
import { PanelDataErrorView } from '@grafana/runtime';
|
||||
import {
|
||||
AdHocFilterItem,
|
||||
TooltipDisplayMode,
|
||||
@@ -174,11 +174,7 @@ export const BarChartPanel = (props: PanelProps<Options>) => {
|
||||
// Fields may later be marked as not filterable. For example, fields created from Grafana Transforms that
|
||||
// are derived from a data source, but are not present in the data source.
|
||||
// We choose `xField` here because it contains the label-value pair, rather than `field` which is the numeric Value.
|
||||
if (
|
||||
config.featureToggles.adhocFiltersInTooltips &&
|
||||
xField.config.filterable &&
|
||||
onAddAdHocFilter != null
|
||||
) {
|
||||
if (xField.config.filterable && onAddAdHocFilter != null) {
|
||||
const adHocFilterItem: AdHocFilterItem = {
|
||||
key: xField.name,
|
||||
operator: FILTER_FOR_OPERATOR,
|
||||
|
||||
Reference in New Issue
Block a user