public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NestedFolders: Enable new nested folder picker by default for nested folders (#72129)

Browse Source 
NestedFolders: Enable new nested folder picker by default
This commit is contained in:
Josh Hunt
2023-07-24 13:51:00 +00:00
committed by GitHub
parent ee60d8c82d
commit f917fbfe42
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
+1 -1
View File
@@ -29,6 +29,7 @@ Some features are enabled by default. You can disable these feature by setting t
| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | Yes |
| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | Yes |
| `newPanelChromeUI` | Show updated look and feel of grafana-ui PanelChrome: panel header, icons, and menu | Yes |
| `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the folderPicker feature flag | Yes |
| `accessTokenExpirationCheck` | Enable OAuth access_token expiration check and token refresh using the refresh_token | |
| `emptyDashboardPage` | Enable the redesigned user interface of a dashboard page that includes no panels | Yes |
| `disablePrometheusExemplarSampling` | Disable Prometheus exemplar sampling | |
@@ -89,7 +90,6 @@ Experimental features might be changed or removed without prior notice.
| `logRequestsInstrumentedAsUnknown` | Logs the path for requests that are instrumented as unknown |
| `showDashboardValidationWarnings` | Show warnings when dashboards do not validate against the schema |
| `mysqlAnsiQuotes` | Use double quotes to escape keyword in a MySQL query |
| `nestedFolderPicker` | Enables the still in-development new folder picker to support nested folders |
| `alertingBacktesting` | Rule backtesting API for alerting |
| `editPanelCSVDragAndDrop` | Enables drag and drop for CSV and Excel files |
| `lokiQuerySplittingConfig` | Give users the option to configure split durations for Loki queries |
pkg/services/featuremgmt/registry.go
+6 -4
View File
@@ -240,10 +240,12 @@ var (
Owner: grafanaBackendPlatformSquad,
},
{
Name: "nestedFolderPicker",
Description: "Enables the still in-development new folder picker to support nested folders",
Stage: FeatureStageExperimental,
Owner: grafanaFrontendPlatformSquad,
Name: "nestedFolderPicker",
Description: "Enables the new folder picker to work with nested folders. Requires the folderPicker feature flag",
Stage: FeatureStageGeneralAvailability,
Owner: grafanaFrontendPlatformSquad,
FrontendOnly: true,
Expression: "true", // enabled by default
},
{
Name: "accessTokenExpirationCheck",
pkg/services/featuremgmt/toggles_gen.csv
+1 -1
View File
@@ -34,7 +34,7 @@ showDashboardValidationWarnings,experimental,@grafana/dashboards-squad,false,fal
mysqlAnsiQuotes,experimental,@grafana/backend-platform,false,false,false,false
accessControlOnCall,preview,@grafana/grafana-authnz-team,false,false,false,false
nestedFolders,preview,@grafana/backend-platform,false,false,false,false
nestedFolderPicker,experimental,@grafana/grafana-frontend-platform,false,false,false,false
nestedFolderPicker,GA,@grafana/grafana-frontend-platform,false,false,false,true
accessTokenExpirationCheck,GA,@grafana/grafana-authnz-team,false,false,false,false
emptyDashboardPage,GA,@grafana/dashboards-squad,false,false,false,true
disablePrometheusExemplarSampling,GA,@grafana/observability-metrics,false,false,false,false
1 Name Stage Owner requiresDevMode RequiresLicense RequiresRestart FrontendOnly
34 mysqlAnsiQuotes experimental @grafana/backend-platform false false false false
35 accessControlOnCall preview @grafana/grafana-authnz-team false false false false
36 nestedFolders preview @grafana/backend-platform false false false false
37 nestedFolderPicker experimental GA @grafana/grafana-frontend-platform false false false false true
38 accessTokenExpirationCheck GA @grafana/grafana-authnz-team false false false false
39 emptyDashboardPage GA @grafana/dashboards-squad false false false true
40 disablePrometheusExemplarSampling GA @grafana/observability-metrics false false false false
pkg/services/featuremgmt/toggles_gen.go
+1 -1
View File
@@ -148,7 +148,7 @@ const (
FlagNestedFolders = "nestedFolders"
// FlagNestedFolderPicker
// Enables the still in-development new folder picker to support nested folders
// Enables the new folder picker to work with nested folders. Requires the folderPicker feature flag
FlagNestedFolderPicker = "nestedFolderPicker"
// FlagAccessTokenExpirationCheck
pkg/services/featuremgmt/toggles_gen_test.go
+1 -1
View File
@@ -31,7 +31,7 @@ func TestFeatureToggleFiles(t *testing.T) {
t.Run("check registry constraints", func(t *testing.T) {
for _, flag := range standardFeatureFlags {
if flag.Expression == "true" && flag.Stage != FeatureStageGeneralAvailability {
t.Errorf("only stable features can be enabled by default. See: %s", flag.Name)
t.Errorf("only FeatureStageGeneralAvailability features can be enabled by default. See: %s", flag.Name)
}
if flag.RequiresDevMode && flag.Stage != FeatureStageExperimental {
t.Errorf("only alpha features can require dev mode. See: %s", flag.Name)