Fix Grafana App SDK logger log level (#115551)

* Fix Grafana App SDK logger log level

What

This commit fixes the hardcoded value of the app SDK logger log level
by properly setting it during the log manager initialization.

Why

To prevent app SDK logging from always logging at DEBUG.

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

* Add missing argument to the logging test

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

---------

Signed-off-by: Igor Suleymanov <igor.suleymanov@grafana.com>

pkg/infra/log/log.go

@@ -54,7 +54,8 @@ func init() {
 	}
 	logger := level.NewFilter(format(os.Stderr), level.AllowInfo())
 	root = newManager(logger)
-	initAppSDKLogger(logger)
+	// Use default Info level during package initialization before config is loaded
+	initAppSDKLogger(logger, slog.LevelInfo)
 
 	RegisterContextualLogProvider(func(ctx context.Context) ([]any, bool) {
 		pFromCtx := ctx.Value(logParamsContextKey{})
@@ -80,7 +81,7 @@ func newManager(logger gokitlog.Logger) *logManager {
 	}
 }
 
-func (lm *logManager) initialize(loggers []logWithFilters) {
+func (lm *logManager) initialize(loggers []logWithFilters, levelStr string) {
 	lm.mutex.Lock()
 	defer lm.mutex.Unlock()
 
@@ -113,7 +114,7 @@ func (lm *logManager) initialize(loggers []logWithFilters) {
 		lm.loggersByName[name].Swap(&compositeLogger{loggers: ctxLoggers})
 	}
 
-	initAppSDKLogger(lm.ConcreteLogger)
+	initAppSDKLogger(lm.ConcreteLogger, stringToSlogLevel(levelStr))
 }
 
 func (lm *logManager) New(ctx ...any) *ConcreteLogger {
@@ -514,7 +515,7 @@ func ReadLoggingConfig(modes []string, logsPath string, cfg *ini.File) error {
 		configLoggers = append(configLoggers, handler)
 	}
 	if len(configLoggers) > 0 {
-		root.initialize(configLoggers)
+		root.initialize(configLoggers, defaultLevelName)
 	}
 
 	return nil
@@ -551,8 +552,22 @@ func SetupConsoleLogger(level string) error {
 	return nil
 }
 
-func initAppSDKLogger(gkl gokitlog.Logger) {
-	// We need to allow Debug logs here. go-kit/log does not support sharing the level we're using.
-	// TODO: Refactor such that we can pass in a level in a more appropriate manner.
-	logging.DefaultLogger = logging.NewSLogLogger(sloggokit.NewGoKitHandler(gkl, slog.LevelDebug))
+// stringToSlogLevel converts a log level string to slog.Level
+func stringToSlogLevel(levelStr string) slog.Level {
+	switch strings.ToLower(levelStr) {
+	case "trace", "debug":
+		return slog.LevelDebug
+	case "info":
+		return slog.LevelInfo
+	case "warn", "warning":
+		return slog.LevelWarn
+	case "error", "critical":
+		return slog.LevelError
+	default:
+		return slog.LevelInfo
+	}
+}
+
+func initAppSDKLogger(gkl gokitlog.Logger, level slog.Level) {
+	logging.DefaultLogger = logging.NewSLogLogger(sloggokit.NewGoKitHandler(gkl, level))
 }

pkg/infra/log/log_test.go

@@ -88,7 +88,7 @@ func TestNew(t *testing.T) {
 				val:      swapLogger,
 				maxLevel: level.AllowAll(),
 			},
-		})
+		}, "info")
 
 		err := log1.Log("msg", "hello 1")
 		require.NoError(t, err)